Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1393595

Re: [PATCH] lightnvm: pass dma address to hardware rather than pointer

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> 
> On 03 May 2016, at 17:22, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> A recent change to lightnvm added code to pass a kernel pointer
> to the hardware, which gcc complained about:
> 
> drivers/nvme/host/lightnvm.c: In function 'nvme_nvm_rqtocmd':
> drivers/nvme/host/lightnvm.c:472:32: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>  c->ph_rw.metadata = cpu_to_le64(rqd->meta_list);
> 
> It looks like this has no way of working anyway, so this changes
> the code to pass the dma_address instead. This was most likely
> what was intended here. Neither of the two are currently ever
> written to, so the effect is the same for now.
> 

Thanks Arnd.

It was my mistake. I had it fixed in the pblk branch, where we use the
metadata field and was waiting to send it together with other fixes.

Javier.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] lightnvm: pass dma address to hardware rather than pointer Arnd Bergmann <arnd@arndb.de> - 2016-05-03 17:30 +0200
  Re: [PATCH] lightnvm: pass dma address to hardware rather than  pointer Javier González <javier@cnexlabs.com> - 2016-05-03 18:30 +0200
  Re: [PATCH] lightnvm: pass dma address to hardware rather than  pointer Matias Bjørling <m@bjorling.me> - 2016-05-03 19:50 +0200

csiph-web