Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1393542

Re: [PATCH] efivarfs: merge boolean flag arguments

Show all headers | View raw

On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote:
> The parameters atomic and duplicates of efivar_init always have opposite
> values.  Drop the parameter atomic, replace the uses of !atomic with
> duplicates, and update the call sites accordingly.
> 
> The code using duplicates is slightly reorganized with an else, to avoid
> duplicating the lock code.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
> Not tested.  I have assumed that the calls to both variable_is_present and
> dup_variable_bug need to be out of the lock.
> 
>  drivers/firmware/efi/efivars.c |    5 ++---
>  drivers/firmware/efi/vars.c    |   23 ++++++++++-------------
>  fs/efivarfs/super.c            |    3 +--
>  include/linux/efi.h            |    3 +--
>  4 files changed, 14 insertions(+), 20 deletions(-)

Applied. Thanks Julia.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] efivarfs: merge boolean flag arguments Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-03 17:40 +0200

csiph-web