Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1393452

Re: [report] invalid error code in do_register_con_driver() console

Show all headers | View raw

On 02/25/2016, 10:34 PM, Dan Carpenter wrote:
> Hi Jiri,
> 
> I'm getting the following static checker warning:
> 
> 	drivers/tty/vt/vt.c:3588 do_register_con_driver()
> 	warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0'
> 
> drivers/tty/vt/vt.c
>   3582          if (retval)
>   3583                  goto err;
>   3584  
>   3585          desc = csw->con_startup();
>   3586  
>   3587          if (!desc)
>   3588                  goto err;
>   3589  
>   3590          retval = -EINVAL;
>   3591  
> 
> Probably, we could more the "retval = -EINVAL;" before the goto?  I
> don't think it's intentional?

Yes, you are right. I've prepared a fix to send out.

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [report] invalid error code in do_register_con_driver() console Jiri Slaby <jslaby@suse.cz> - 2016-05-03 16:30 +0200

csiph-web