Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

From	Vignesh R <vigneshr@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes
Date	2016-05-03 14:10 +0200
Message-ID	<ruHjk-7XO-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <rmFeG-2HC-19@gated-at.bofh.it> <rmOhX-1e7-1@gated-at.bofh.it> <rmOUG-1Pg-21@gated-at.bofh.it> <rmQts-3h1-13@gated-at.bofh.it> <rn9Z7-2vk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 04/12/2016 10:33 PM, Sebastian Andrzej Siewior wrote:
> On 04/11/2016 10:10 PM, Peter Hurley wrote:
>> On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote:
>>> On 04/11/2016 07:53 PM, Peter Hurley wrote:
>>>> On 04/11/2016 01:18 AM, John Ogness wrote:
>>>>> On 2016-04-05, Peter Hurley <peter@hurleysoftware.com> wrote:
>>>>>> On 03/31/2016 01:41 AM, John Ogness wrote:

[...]

>> *am335x*
> 
> I am not sure if the limitations are based on the DMA engine or the
> 
>> - requires write to tx fifo to trigger tx dma (ie. OMAP_DMA_TX_KICK
>>   workaround necessitating completely different tx dma completion handler)
> 
> This one for instance I don't see on BeagleBoard xM / omap36xx and
> DRA7x. Both (not affected) use SDMA instead EDMA. It would be
> interesting to see if DRA7x is affected once it uses EDMA.
> 

8250 UART DMA works fine with EDMA as the DMA engine.
As per my testing, am335x + EDMA, am437x + EDMA, dra7xx + EDMA and
dra72x + EDMA require OMAP_DMA_TX_KICK quirk. However when using SDMA
OMAP_DMA_TX_KICK is not needed (I tested on dra7xx platform). So, it can
be concluded that when using EDMA with 8250 UART tx kick is needed.



-- 
Regards
Vignesh

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes Vignesh R <vigneshr@ti.com> - 2016-05-03 14:10 +0200

csiph-web