Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393361
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface |
| Date | 2016-05-03 14:00 +0200 |
| Message-ID | <ruH9F-7wB-17@gated-at.bofh.it> (permalink) |
| References | <rta66-1ix-15@gated-at.bofh.it> <rta66-1ix-19@gated-at.bofh.it> <rujTI-2ar-19@gated-at.bofh.it> <ruxDm-6UV-73@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: > On 05/02/2016 07:00 PM, Mark Brown wrote: > > On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > >> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); > >> + if (IS_ERR(gpiod)) > >> + return PTR_ERR(gpiod); > > This is clearly an inappropriate name for the signal in generic code, > > it's specific to your use case. > I will change the gpio name to "gpio". Is that okay? Yes, that looks good (and lines up with DT so hopefully the code can be shared).
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v7 1/7] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-29 08:30 +0200
Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-05-02 13:10 +0200
Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-05-03 03:50 +0200
Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-05-03 14:00 +0200
Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-05-04 02:30 +0200
csiph-web