Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393251
| From | David Laight <David.Laight@ACULAB.COM> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code. |
| Date | 2016-05-03 11:50 +0200 |
| Message-ID | <ruF7Q-5LC-11@gated-at.bofh.it> (permalink) |
| References | <rtsPo-eM-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Konstantin Shkolnyy > Sent: 30 April 2016 03:22 > Replaced magic numbers used in the CRTSCTS flag code with symbolic names > from the chip specification. > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> > --- > Changes in v2: > Improved CRTSCTS fix based on feedback. Dropped get_termios error handling. > > drivers/usb/serial/cp210x.c | 93 +++++++++++++++++++++++++++++++++------------ > 1 file changed, 69 insertions(+), 24 deletions(-) > > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c ... > +/* cp210x_flow_ctl::ulControlHandshake */ > +#define SERIAL_DTR_MASK 0x00000003 > +#define SERIAL_CTS_HANDSHAKE 0x00000008 > +#define SERIAL_DSR_HANDSHAKE 0x00000010 > +#define SERIAL_DCD_HANDSHAKE 0x00000020 > +#define SERIAL_DSR_SENSITIVITY 0x00000040 ... I'd have thought the names ought to start CP210X_ David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code. Konstantin Shkolnyy <konstantin.shkolnyy@gmail.com> - 2016-04-30 04:30 +0200
RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code. David Laight <David.Laight@ACULAB.COM> - 2016-05-03 11:50 +0200
RE: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code. Konstantin Shkolnyy <Konstantin.Shkolnyy@silabs.com> - 2016-05-03 14:20 +0200
Re: [EXT] RE: [PATCH v2 2/3] USB: serial: cp210x: Added comments to CRTSCTS flag code. Johan Hovold <johan@kernel.org> - 2016-05-03 14:30 +0200
csiph-web