Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call

From	Martin Schwidefsky <schwidefsky@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call
Date	2016-05-03 09:30 +0200
Message-ID	<ruCWm-3Cj-5@gated-at.bofh.it> (permalink)
References	<rui1A-FW-1@gated-at.bofh.it> <rujAl-1I4-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2 May 2016 12:43:56 +0200
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Mon, May 02, 2016 at 11:00:12AM +0200, Anna-Maria Gleixner wrote:
> > Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out
> > in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
> > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
> > function calls are no longer required.
> > 
> > Replace smp_call_function_single() with a direct call of
> > setup_pmc_cpu(). To keep the calling convention, interrupts are
> > explicitly disabled around the call.
> > 
> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Cc: linux-s390@vger.kernel.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > ---
> > Changes in v2:
> > 	- Adapt referenced commit in commit message
> > 
> >  arch/s390/kernel/perf_cpum_sf.c |    9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> 
> Same here: Martin, can you pick this one up, please?

Applied as well.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] s390/cpum_sf: Remove superfluous SMP function call Anna-Maria Gleixner <anna-maria@linutronix.de> - 2016-05-02 11:10 +0200
  Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-05-02 12:50 +0200
    Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-05-03 09:30 +0200

csiph-web