Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393031
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] zram: user per-cpu compression streams |
| Date | 2016-05-03 06:30 +0200 |
| Message-ID | <ruA8a-15s-15@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <ruikW-Pa-7@gated-at.bofh.it> <ruxDj-6UV-11@gated-at.bofh.it> <ruxN3-70R-67@gated-at.bofh.it> <ruyg2-7Lh-3@gated-at.bofh.it> <ruyg1-7Lh-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On (05/03/16 11:30), Sergey Senozhatsky wrote:
> > We are concerning about returing back to no per-cpu options but actually,
> > I don't want. If duplicate compression is really problem(But It's really
> > unlikely), we should try to solve the problem itself with different way
> > rather than roll-back to old, first of all.
> >
> > I hope we can. So let's not add big worry about adding new dup stat. :)
>
> ok, no prob. do you want it a separate sysfs node or a column in mm_stat?
> I'd prefer mm_stat column, or somewhere in those cumulative files; not a
> dedicated node: we decided to get rid of them some time ago.
>
will io_stat node work for you?
I'll submit a formal patch later today. when you have time, can you
take a look at http://marc.info/?l=linux-kernel&m=146217628030970 ?
I think we can fold this one into 0002. it will make 0002 slightly
bigger, but there nothing complicated in there, just cleanup.
====
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: [PATCH] zram: export the number of re-compressions
Make the number of re-compressions visible via the io_stat node,
so we will be able to track down any issues caused by per-cpu
compression streams.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Suggested-by: Minchan Kim <minchan@kernel.org>
---
Documentation/blockdev/zram.txt | 3 +++
drivers/block/zram/zram_drv.c | 7 +++++--
drivers/block/zram/zram_drv.h | 1 +
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/blockdev/zram.txt b/Documentation/blockdev/zram.txt
index 5bda503..386d260 100644
--- a/Documentation/blockdev/zram.txt
+++ b/Documentation/blockdev/zram.txt
@@ -183,6 +183,8 @@ mem_limit RW the maximum amount of memory ZRAM can use to store
pages_compacted RO the number of pages freed during compaction
(available only via zram<id>/mm_stat node)
compact WO trigger memory compaction
+num_recompress RO the number of times fast compression paths failed
+ and zram performed re-compression via a slow path
WARNING
=======
@@ -215,6 +217,7 @@ whitespace:
failed_writes
invalid_io
notify_free
+ num_recompress
File /sys/block/zram<id>/mm_stat
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 817e511..11b19c9 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -395,7 +395,8 @@ static ssize_t io_stat_show(struct device *dev,
(u64)atomic64_read(&zram->stats.failed_reads),
(u64)atomic64_read(&zram->stats.failed_writes),
(u64)atomic64_read(&zram->stats.invalid_io),
- (u64)atomic64_read(&zram->stats.notify_free));
+ (u64)atomic64_read(&zram->stats.notify_free),
+ (u64)atomic64_read(&zram->stats.num_recompress));
up_read(&zram->init_lock);
return ret;
@@ -721,8 +722,10 @@ compress_again:
handle = zs_malloc(meta->mem_pool, clen,
GFP_NOIO | __GFP_HIGHMEM);
- if (handle)
+ if (handle) {
+ atomic64_inc(&zram->stats.num_recompress);
goto compress_again;
+ }
pr_err("Error allocating memory for compressed page: %u, size=%zu\n",
index, clen);
diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h
index 06b1636..78d7e8f 100644
--- a/drivers/block/zram/zram_drv.h
+++ b/drivers/block/zram/zram_drv.h
@@ -85,6 +85,7 @@ struct zram_stats {
atomic64_t zero_pages; /* no. of zero filled pages */
atomic64_t pages_stored; /* no. of pages currently stored */
atomic_long_t max_used_pages; /* no. of maximum pages stored */
+ atomic64_t num_recompress; /* no. of failed compression fast paths */
};
struct zram_meta {
--
2.8.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] zram: switch to per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-04-28 17:30 +0200
[PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-04-28 17:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-02 08:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-02 09:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-02 10:10 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-03 07:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-03 07:50 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-03 07:50 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-03 08:00 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-03 08:20 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-03 09:00 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-02 10:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-02 11:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-03 03:50 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-03 04:00 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-03 04:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-03 06:30 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-03 07:10 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-05-03 09:00 +0200
Re: [PATCH 2/2] zram: user per-cpu compression streams Minchan Kim <minchan@kernel.org> - 2016-05-03 04:30 +0200
[PATCH 1/2] zsmalloc: require GFP in zs_malloc() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-04-28 17:30 +0200
Re: [PATCH 1/2] zsmalloc: require GFP in zs_malloc() Minchan Kim <minchan@kernel.org> - 2016-04-29 07:50 +0200
Re: [PATCH 1/2] zsmalloc: require GFP in zs_malloc() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-29 09:30 +0200
csiph-web