Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module
Date	2016-05-01 23:30 +0200
Message-ID	<ru76a-86o-13@gated-at.bofh.it> (permalink)
References	<rtsw2-8n4-1@gated-at.bofh.it> <rtsFI-8U-9@gated-at.bofh.it> <rtWaK-7nA-5@gated-at.bofh.it> <ru5nI-6Cf-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun 2016-05-01 21:34:10, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, May 01, 2016 at 11:43:49AM +0200, Pavel Machek wrote:
> > > +++ b/drivers/hsi/controllers/Makefile
> > > @@ -2,5 +2,5 @@
> > >  # Makefile for HSI controllers drivers
> > >  #
> > >  
> > > -obj-$(CONFIG_OMAP_SSI)		+= omap_ssi.o
> > > -obj-$(CONFIG_OMAP_SSI_PORT)	+= omap_ssi_port.o
> > > +omap_ssi-objs		+= omap_ssi_core.o omap_ssi_port.o
> > > +obj-$(CONFIG_OMAP_SSI)	+= omap_ssi.o
> > 
> > Can you simply do
> > 
> > obj-$(CONFIG_OMAP_SSI)       +=  omap_ssi_core.o omap_ssi_port.o
> 
> No, that would result in omap_ssi_core.ko and omap_ssi_port.ko if
> CONFIG_OMAP_SSI is enabled. Basically it's an optimized variant of
> the current behaviour, but it still builds two modules.

Aha... I was not thinking about modular build.

Acked-by: Pavel Machek <pavel@ucw.cz>

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

[PATCH 0/6] omap-ssi cleanups + dvfs support Sebastian Reichel <sre@kernel.org> - 2016-04-30 04:10 +0200
  [PATCH 3/6] HSI: omap_ssi: make sure probe stays available Sebastian Reichel <sre@kernel.org> - 2016-04-30 04:10 +0200
  [PATCH 4/6] HSI: omap_ssi: fix removal of port platform device Sebastian Reichel <sre@kernel.org> - 2016-04-30 04:10 +0200
    Re: [PATCH 4/6] HSI: omap_ssi: fix removal of port platform device Pavel Machek <pavel@ucw.cz> - 2016-05-01 11:50 +0200
  [PATCH 1/6] HSI: omap_ssi_port: switch to gpiod API Sebastian Reichel <sre@kernel.org> - 2016-04-30 04:10 +0200
    Re: [PATCH 1/6] HSI: omap_ssi_port: switch to gpiod API Pavel Machek <pavel@ucw.cz> - 2016-05-02 09:10 +0200
  [PATCH 6/6] HSI: omap-ssi: add clk change support Sebastian Reichel <sre@kernel.org> - 2016-04-30 04:20 +0200
    Re: [PATCH 6/6] HSI: omap-ssi: add clk change support Pavel Machek <pavel@ucw.cz> - 2016-05-01 12:10 +0200
  [PATCH 2/6] HSI: omap_ssi: fix module unloading Sebastian Reichel <sre@kernel.org> - 2016-04-30 04:20 +0200
    Re: [PATCH 2/6] HSI: omap_ssi: fix module unloading Pavel Machek <pavel@ucw.cz> - 2016-05-02 09:10 +0200
  [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module Sebastian Reichel <sre@kernel.org> - 2016-04-30 04:20 +0200
    Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into  one module Pavel Machek <pavel@ucw.cz> - 2016-05-01 11:50 +0200
      Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into  one module Sebastian Reichel <sre@kernel.org> - 2016-05-01 21:40 +0200
        Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into  one module Pavel Machek <pavel@ucw.cz> - 2016-05-01 23:30 +0200
    Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into  one module Tony Lindgren <tony@atomide.com> - 2016-05-03 19:40 +0200
      Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into  one module Sebastian Reichel <sre@kernel.org> - 2016-05-09 22:50 +0200
        Re: [PATCH 5/6] HSI: omap_ssi: built omap_ssi and omap_ssi_port into  one module Tony Lindgren <tony@atomide.com> - 2016-05-09 23:40 +0200

csiph-web