[PATCH 2/3] ext2: Add alignment check for DAX mount

From	Toshi Kani <toshi.kani@hpe.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/3] ext2: Add alignment check for DAX mount
Date	2016-04-29 22:50 +0200
Message-ID	<rtnwl-3Q2-1@gated-at.bofh.it> (permalink)
References	<rtnwl-3Q2-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When a partition is not aligned by 4KB, mount -o dax succeeds,
but any read/write access to the filesystem fails, except for
metadata update.

Add alignment check to ext2_fill_super() when -o dax is specified.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 fs/ext2/super.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index b78caf2..34e32d9 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -927,6 +927,12 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
 					"error: unsupported blocksize for dax");
 			goto failed_mount;
 		}
+		if (sb->s_bdev->bd_part->start_sect % (PAGE_SIZE / 512) ||
+		    sb->s_bdev->bd_part->nr_sects % (PAGE_SIZE / 512)) {
+			ext2_msg(sb, KERN_ERR,
+					"error: unaligned partition for dax");
+			goto failed_mount;
+		}
 		if (!sb->s_bdev->bd_disk->fops->direct_access) {
 			ext2_msg(sb, KERN_ERR,
 					"error: device does not support dax");

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/3] ext2: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-04-29 22:50 +0200

csiph-web