Re: [PATCH] klp: make object/func-walking helpers more robust

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] klp: make object/func-walking helpers more robust
Date	Fri, 29 Apr 2016 18:30:04 +0200
Message-ID	<rtjsM-HD-55@gated-at.bofh.it> (permalink)
References	<rsVgL-4Ob-33@gated-at.bofh.it>
X-Original-To	Miroslav Benes <mbenes@suse.cz>
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.6.0.1 (2016-04-01)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.22
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	jeyu@redhat.com, jikos@kernel.org, pmladek@suse.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 29 Apr 2016 11:23:20 -0500
X-Original-Message-ID	<20160429162320.swgc4emtok4euo3t@treble>
X-Original-References	<1461854048-31473-1-git-send-email-mbenes@suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1391280

Show key headers only | View raw

On Thu, Apr 28, 2016 at 04:34:08PM +0200, Miroslav Benes wrote:
> Current object-walking helper checks the presence of obj->funcs to
> determine the end of objs array in klp_object structure. This is
> somewhat fragile because one can easily forget about funcs definition
> during livepatch creation. In such a case the livepatch module is
> successfully loaded and all objects after the incorrect one are omitted.
> This is very confusing. Let's make the helper more robust and check also
> for the other external member, name. Thus the helper correctly stops on
> an empty item of the array. We need to have a check for obj->funcs in
> klp_init_object() to make it work.
> 
> The same applies to a func-walking helper.
> 
> As a benefit we'll check for new_func member definition during the
> livepatch initialization. There is no such check anywhere in the code
> now.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

Thread

[PATCH] klp: make object/func-walking helpers more robust Miroslav Benes <mbenes@suse.cz> - 2016-04-28 16:40 +0200
  Re: klp: make object/func-walking helpers more robust Jessica Yu <jeyu@redhat.com> - 2016-04-28 20:30 +0200
    Re: klp: make object/func-walking helpers more robust Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-28 23:20 +0200
      Re: klp: make object/func-walking helpers more robust Miroslav Benes <mbenes@suse.cz> - 2016-04-29 09:50 +0200
        Re: klp: make object/func-walking helpers more robust Jessica Yu <jeyu@redhat.com> - 2016-04-29 18:20 +0200
    Re: klp: make object/func-walking helpers more robust Jiri Kosina <jikos@kernel.org> - 2016-04-29 10:40 +0200
  Re: klp: make object/func-walking helpers more robust Jessica Yu <jeyu@redhat.com> - 2016-04-29 18:30 +0200
  Re: [PATCH] klp: make object/func-walking helpers more robust Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-29 18:30 +0200
  Re: [PATCH] klp: make object/func-walking helpers more robust Jiri Kosina <jikos@kernel.org> - 2016-04-30 00:10 +0200

csiph-web