Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391291

Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader initialization

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 29, 2016 at 01:55:14PM +0200, Krzysztof Kozlowski wrote:
> On 04/29/2016 01:30 PM, Mark Brown wrote:

> > Supplies are only optional if they may be physically absent.  In this
> > case it's possible that on device regulators may be used instead, a
> > pattern more like that used for arizona-ldo1 where we represent those
> > regulators might be better as it's more clearly describing the
> > situation.  I'm just wondering if the supply lookup stuff there should
> > be factored out as this is not an uncommon pattern..

> > It should at least be clearly stated what's going on, ignoring failure
> > to get supplies is generally a bug and people will tend to blindly cut
> > and paste things (witness all the breakage in graphics drivers with
> > this).

> The VDD33 is really optional. The device can work in different
> configuration, e.g. only on VBAT. How the reset logic would work then? I
> don't know... I would suspect that it could be exactly the same (just
> replace VDD33 with VBAT) but I am not sure.

What the Arizona example I mentioned does is look for the property
specifying an external supply in DT and if there isn't one assumes that
it must be using the internal regulator.  That's a bit icky but it does
the right thing and is much simpler from a user point of view.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-29 13:10 +0200
  [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader  initialization Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-29 13:10 +0200
    Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after  bootloader initialization Mark Brown <broonie@kernel.org> - 2016-04-29 13:40 +0200
      Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader  initialization Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-29 14:00 +0200
        Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after  bootloader initialization Mark Brown <broonie@kernel.org> - 2016-04-29 18:50 +0200
          Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader  initialization Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-02 11:50 +0200
            Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader  initialization Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-02 12:50 +0200
            Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after  bootloader initialization Mark Brown <broonie@kernel.org> - 2016-05-02 13:00 +0200
              Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after  bootloader initialization Rob Herring <robh@kernel.org> - 2016-05-03 20:10 +0200
                Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after bootloader  initialization Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-04 14:10 +0200
                Re: [RFT PATCH 1/3] usb: misc: usb3503: Fix HUB mode after  bootloader initialization Mark Brown <broonie@kernel.org> - 2016-05-04 20:30 +0200
  Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Hans Verkuil <hverkuil@xs4all.nl> - 2016-04-30 11:50 +0200
    Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-01 15:20 +0200
      Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Hans Verkuil <hverkuil@xs4all.nl> - 2016-05-01 16:20 +0200
        Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Hans Verkuil <hverkuil@xs4all.nl> - 2016-05-01 18:10 +0200
          Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-01 18:50 +0200
            Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Hans Verkuil <hverkuil@xs4all.nl> - 2016-05-02 15:50 +0200
              Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-02 15:50 +0200
          Re: [RFT PATCH 0/3] usb: misc: usb3503: Fix missing device when TFTP  booting Marek Szyprowski <m.szyprowski@samsung.com> - 2016-05-02 08:00 +0200

csiph-web