Re: [PATCH v4 07/13] USB: ch341: add debug output for chip version

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 07/13] USB: ch341: add debug output for chip version
Date	2016-04-29 15:20 +0200
Message-ID	<rtguT-6Au-11@gated-at.bofh.it> (permalink)
References	<rojjH-119-3@gated-at.bofh.it> <rojjK-119-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 15, 2016 at 11:14:10PM +0200, Grigori Goronzy wrote:
> There are at least two hardware revisions, this may be helpful in
> case compatibility issues need to be debugged.
> 
> Signed-off-by: Grigori Goronzy <greg@chown.ath.cx>
> ---
>  drivers/usb/serial/ch341.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
> index 2fbec4a..e475677 100644
> --- a/drivers/usb/serial/ch341.c
> +++ b/drivers/usb/serial/ch341.c
> @@ -209,6 +209,7 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv)
>  	r = ch341_control_in(dev, CH341_VERSION, 0, 0, buffer, size);
>  	if (r < 0)
>  		goto out;
> +	dev_dbg(&dev->dev, "Chip version: %d\n", buffer[0]);

0x%02x?

>  
>  	r = ch341_control_out(dev, CH341_SERIAL_INIT, 0, 0);
>  	if (r < 0)

Thanks,
Johan

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 07/13] USB: ch341: add debug output for chip version Johan Hovold <johan@kernel.org> - 2016-04-29 15:20 +0200

csiph-web