[PATCH v2] crypto: Add a flag allowing the self-tests to be disabled at runtime.

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	"Richard W.M. Jones" <rjones@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] crypto: Add a flag allowing the self-tests to be disabled at runtime.
Date	Fri, 29 Apr 2016 13:10:02 +0200
Message-ID	<rtet4-4St-29@gated-at.bofh.it> (permalink)
References	<rtet4-4St-23@gated-at.bofh.it>
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.24
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	corbet@lwn.net, herbert@gondor.apana.org.au, davem@davemloft.net, linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org
X-Original-Date	Fri, 29 Apr 2016 12:03:04 +0100
X-Original-Message-ID	<1461927784-19114-2-git-send-email-rjones@redhat.com>
X-Original-References	<1461927784-19114-1-git-send-email-rjones@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1391010

Show key headers only | View raw

Running self-tests for a short-lived KVM VM takes 28ms on my laptop.
This commit adds a flag 'cryptomgr.notests' which allows them to be
disabled.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 Documentation/kernel-parameters.txt | 3 +++
 crypto/testmgr.c                    | 9 +++++++++
 2 files changed, 12 insertions(+)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 0b3de80..d4d5fb7 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -826,6 +826,9 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
 			It will be ignored when crashkernel=X,high is not used
 			or memory reserved is below 4G.
 
+	cryptomgr.notests
+                        [KNL] Disable crypto self-tests
+
 	cs89x0_dma=	[HW,NET]
 			Format: <dma>
 
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index b86883a..5c0664d 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -35,6 +35,10 @@
 
 #include "internal.h"
 
+static bool notests;
+module_param(notests, bool, 0644);
+MODULE_PARM_DESC(notests, "disable crypto self-tests");
+
 #ifdef CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
 
 /* a perfect nop */
@@ -3868,6 +3872,11 @@ int alg_test(const char *driver, const char *alg, u32 type, u32 mask)
 	int j;
 	int rc;
 
+	if (notests) {
+		printk_once(KERN_INFO "alg: self-tests disabled\n");
+		return 0;
+	}
+
 	alg_test_descs_check_order();
 
 	if ((type & CRYPTO_ALG_TYPE_MASK) == CRYPTO_ALG_TYPE_CIPHER) {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] crypto: Add a flag allowing the self-tests to be disabled at runtime. "Richard W.M. Jones" <rjones@redhat.com> - 2016-04-29 13:10 +0200
  Re: [PATCH v2] crypto: Add a flag allowing the self-tests to be  disabled at runtime. Herbert Xu <herbert@gondor.apana.org.au> - 2016-05-03 09:40 +0200

csiph-web