Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390804

Re: [PATCH v4] x86/boot: Warn on future overlapping memcpy() use

Show key headers only | View raw

* Kees Cook <keescook@chromium.org> wrote:

> If an overlapping memcpy() is ever attempted, we should at least report
> it, in case it might lead to problems, so it could be changed to a
> memmove() call instead.
> 
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v4:
> - use __memcpy not memcpy since we've already done the check.
> v3:
> - call memmove in addition to doing the warning
> v2:
> - warn about overlapping region
> ---
>  arch/x86/boot/compressed/string.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)

Applied, thanks Kees!

Btw., can we now also remove the memmove() hack from lib/decompress_unxz.c?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] x86/boot: Warn on future overlapping memcpy() use Kees Cook <keescook@chromium.org> - 2016-04-29 02:20 +0200
  Re: [PATCH v4] x86/boot: Warn on future overlapping memcpy() use Ingo Molnar <mingo@kernel.org> - 2016-04-29 08:50 +0200
    Re: [PATCH v4] x86/boot: Warn on future overlapping memcpy() use Kees Cook <keescook@chromium.org> - 2016-04-29 09:00 +0200
      Re: [PATCH v4] x86/boot: Warn on future overlapping memcpy() use Ingo Molnar <mingo@kernel.org> - 2016-04-29 09:30 +0200
  Re: [PATCH v4] x86/boot: Warn on future overlapping memcpy() use Ingo Molnar <mingo@kernel.org> - 2016-04-29 10:00 +0200
    Re: [PATCH v4] x86/boot: Warn on future overlapping memcpy() use Kees Cook <keescook@chromium.org> - 2016-04-29 16:20 +0200

csiph-web