[tip:perf/core] bpf tools: Fix syscall argument

From	tip-bot for Florian Fainelli <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:perf/core] bpf tools: Fix syscall argument
Date	2016-05-01 09:40 +0200
Message-ID	<rtU8W-5EZ-3@gated-at.bofh.it> (permalink)
References	<rrEBk-6GB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Commit-ID:  1a71476e4f2693ed93523c80ff1e2d4a8634717c
Gitweb:     http://git.kernel.org/tip/1a71476e4f2693ed93523c80ff1e2d4a8634717c
Author:     Florian Fainelli <f.fainelli@gmail.com>
AuthorDate: Sun, 24 Apr 2016 19:34:54 -0700
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 28 Apr 2016 09:58:57 -0300

bpf tools: Fix syscall argument

Coverity flagged this under CID 1354884 as a sizeof mismatch, it turns
out that the argument "attr" passed to syscall should have been a
pointer to attr in the first place.

Reported-by: coverity (CID 1354884)
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Wang Nan <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Fixes: 8f9e05fb298f ("perf tools: Fix PowerPC native building")
Link: http://lkml.kernel.org/r/1461551694-5512-3-git-send-email-f.fainelli@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/feature/test-bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
index 8236df9..e04ab89 100644
--- a/tools/build/feature/test-bpf.c
+++ b/tools/build/feature/test-bpf.c
@@ -31,5 +31,5 @@ int main(void)
 	 * Test existence of __NR_bpf and BPF_PROG_LOAD.
 	 * This call should fail if we run the testcase.
 	 */
-	return syscall(__NR_bpf, BPF_PROG_LOAD, attr, sizeof(attr));
+	return syscall(__NR_bpf, BPF_PROG_LOAD, &attr, sizeof(attr));
 }

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[tip:perf/core] bpf tools: Fix syscall argument tip-bot for Florian Fainelli <tipbot@zytor.com> - 2016-05-01 09:40 +0200

csiph-web