Re: [PATCH v2] char: xillybus: use devm_add_action_or_reset

From	Eli Billauer <eli.billauer@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] char: xillybus: use devm_add_action_or_reset
Date	2016-05-01 08:30 +0200
Message-ID	<rtT3c-4G9-3@gated-at.bofh.it> (permalink)
References	<rtFMC-27i-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Fine with me. Thanks.

Acked-by: Eli Billauer <eli.billauer@gmail.com>

On 30/04/16 19:13, Sudip Mukherjee wrote:
> If devm_add_action() fails we are explicitly calling dma_unmap_single(),
> pci_unmap_single() and kfree(). Lets use the helper
> devm_add_action_or_reset() and return directly in case of error, as we
> know that the cleanup function has been already called by the helper if
> there was any error. At that same time remove the variable rc which
> becomes unused now.
>
> Signed-off-by: Sudip Mukherjee<sudip.mukherjee@codethink.co.uk>
> ---
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] char: xillybus: use devm_add_action_or_reset Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-30 18:20 +0200
  Re: [PATCH v2] char: xillybus: use devm_add_action_or_reset Eli Billauer <eli.billauer@gmail.com> - 2016-05-01 08:30 +0200

csiph-web