Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1391730

[PATCH RESEND 4/5] Drivers: hv: balloon: reset host_specified_ha_region

From "K. Y. Srinivasan" <kys@microsoft.com>
Newsgroups linux.kernel
Subject [PATCH RESEND 4/5] Drivers: hv: balloon: reset host_specified_ha_region
Date 2016-05-01 02:50 +0200
Message-ID <rtNKa-k6-13@gated-at.bofh.it> (permalink)
References <rtNK9-k6-1@gated-at.bofh.it> <rtNK9-k6-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Vitaly Kuznetsov <vkuznets@redhat.com>

We set host_specified_ha_region = true on certain request but this is a
global state which stays 'true' forever. We need to reset it when we
receive a request where ha_region is not specified. I did not see any
real issues, the bug was found by code inspection.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/hv_balloon.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 43af913..df35fb7 100644
--- a/drivers/hv/hv_balloon.c
+++ b/drivers/hv/hv_balloon.c
@@ -1400,6 +1400,7 @@ static void balloon_onchannelcallback(void *context)
 				 * This is a normal hot-add request specifying
 				 * hot-add memory.
 				 */
+				dm->host_specified_ha_region = false;
 				ha_pg_range = &ha_msg->range;
 				dm->ha_wrk.ha_page_range = *ha_pg_range;
 				dm->ha_wrk.ha_region_range.page_range = 0;
-- 
1.7.4.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH RESEND 0/5] Drivers: hv: Some miscellaneous fixes  "K. Y. Srinivasan" <kys@microsoft.com> - 2016-05-01 02:50 +0200
  [PATCH RESEND 2/5] Drivers: hv: vmbus: handle various crash scenarios "K. Y. Srinivasan" <kys@microsoft.com> - 2016-05-01 02:50 +0200
  [PATCH RESEND 5/5] tools: hv: lsvmbus: add pci pass-through UUID "K. Y. Srinivasan" <kys@microsoft.com> - 2016-05-01 02:50 +0200
  [PATCH RESEND 3/5] Drivers: hv: balloon: don't crash when memory is added in non-sorted order "K. Y. Srinivasan" <kys@microsoft.com> - 2016-05-01 02:50 +0200
  [PATCH RESEND 4/5] Drivers: hv: balloon: reset host_specified_ha_region "K. Y. Srinivasan" <kys@microsoft.com> - 2016-05-01 02:50 +0200
  [PATCH RESEND 1/5] Drivers: hv: kvp: fix IP Failover "K. Y. Srinivasan" <kys@microsoft.com> - 2016-05-01 02:50 +0200

csiph-web