Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390674

[RFC][PATCH 4.4-stable] regulator: core: Ensure we lock all regulators

Show all headers | View raw

It seems upstream commit 49a6bb7a1c09 ("regulator: core: Ensure
we lock all regulators"), was missed when considering tagging
for -stable.

Without this varient of that patch (the original doesn't apply,
due to a later fix to the same which was backported), I see
double-unlock lockdep splats in the v4.4.8 based HiKey kernel.

Cc: Mark Brown <broonie@kernel.org>
Cc: Tyler Baker <tyler.baker@linaro.org>
Cc: Thierry Reding <treding@nvidia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: stable <stable@vger.kernel.org> # 4.4 only (I think)
Fixes: 3c2c5fb9b99ca ("regulator: core: avoid unused variable warning")
Originally-Reported-by: Tyler Baker <tyler.baker@linaro.org>
Originally-by: Mark Brown <broonie@kernel.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/regulator/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 7b94b8e..732ac71 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -148,7 +148,7 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
 {
 	int i;
 
-	for (i = 0; rdev->supply; rdev = rdev_get_supply(rdev), i++)
+	for (i = 0; rdev; rdev = rdev_get_supply(rdev), i++)
 		mutex_lock_nested(&rdev->mutex, i);
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 4.4-stable] regulator: core: Ensure we lock all regulators John Stultz <john.stultz@linaro.org> - 2016-04-29 02:50 +0200
  Re: [RFC][PATCH 4.4-stable] regulator: core: Ensure we lock all  regulators Mark Brown <broonie@kernel.org> - 2016-04-29 12:30 +0200
  Re: [RFC][PATCH 4.4-stable] regulator: core: Ensure we lock all  regulators Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-06 19:30 +0200
    Re: [RFC][PATCH 4.4-stable] regulator: core: Ensure we lock all regulators John Stultz <john.stultz@linaro.org> - 2016-05-06 20:00 +0200

csiph-web