Re: [PATCH 2/2] tty: serial: msm_serial add info message

From	Frank Rowand <frowand.list@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] tty: serial: msm_serial add info message
Date	2016-04-29 00:20 +0200
Message-ID	<rt2rV-3gl-25@gated-at.bofh.it> (permalink)
References	<rr9nP-6Ka-15@gated-at.bofh.it> <rr9nQ-6Ka-27@gated-at.bofh.it> <rt1cu-21g-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4/28/2016 1:51 PM, Greg Kroah-Hartman wrote:
> On Sat, Apr 23, 2016 at 10:17:05AM -0700, Frank Rowand wrote:
>> From: Frank Rowand <frank.rowand@am.sony.com>
>>
>> Failure to enable DMA by the msm_serial driver is silent.
>> Add a message to report the failure.
>>
>> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
>> ---
>>  drivers/tty/serial/msm_serial.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> Index: b/drivers/tty/serial/msm_serial.c
>> ===================================================================
>> --- a/drivers/tty/serial/msm_serial.c
>> +++ b/drivers/tty/serial/msm_serial.c
>> @@ -170,6 +170,7 @@ rel_tx:
>>  	dma_release_channel(dma->chan);
>>  no_tx:
>>  	memset(dma, 0, sizeof(*dma));
>> +	dev_info(dev, "msm_serial: DMA not enabled\n");
> 
> Don't print out messages that a user can't do something with :(
> 
> So I agree, this is not needed, sorry.
> 
> greg k-h
> 

I am ok with dropping patch 2.  No problem.

-Frank

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] tty: serial: msm_serial add info message Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-28 23:00 +0200
  Re: [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-29 00:20 +0200

csiph-web