Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1390555

[PATCH v4 2/7] dax: fallback from pmd to pte on error

Path csiph.com!news.freedyn.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Vishal Verma <vishal.l.verma@intel.com>
Newsgroups linux.kernel
Subject [PATCH v4 2/7] dax: fallback from pmd to pte on error
Date Thu, 28 Apr 2016 23:30:02 +0200
Message-ID <rt1Fw-2Aw-19@gated-at.bofh.it> (permalink)
References <rt1vQ-2uF-11@gated-at.bofh.it>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.24,548,1455004800"; d="scan'208";a="942415529"
X-Mailer git-send-email 2.5.5
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc Dan Williams <dan.j.williams@intel.com>, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, xfs@oss.sgi.com, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox <matthew@wil.cx>, Ross Zwisler <ross.zwisler@linux.intel.com>, Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>, Jens Axboe <axboe@fb.com>, Al Viro <viro@zeniv.linux.org.uk>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, Jeff Moyer <jmoyer@redhat.com>
X-Original-Date Thu, 28 Apr 2016 15:16:53 -0600
X-Original-Message-ID <1461878218-3844-3-git-send-email-vishal.l.verma@intel.com>
X-Original-References <1461878218-3844-1-git-send-email-vishal.l.verma@intel.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1390555

Show key headers only | View raw


From: Dan Williams <dan.j.williams@intel.com>

In preparation for consulting a badblocks list in pmem_direct_access(),
teach dax_pmd_fault() to fallback rather than fail immediately upon
encountering an error.  The thought being that reducing the span of the
dax request may avoid the error region.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 fs/dax.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/dax.c b/fs/dax.c
index 5a34f08..52f0044 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1111,8 +1111,8 @@ int __dax_pmd_fault(struct vm_area_struct *vma, unsigned long address,
 		long length = dax_map_atomic(bdev, &dax);
 
 		if (length < 0) {
-			result = VM_FAULT_SIGBUS;
-			goto out;
+			dax_pmd_dbg(&bh, address, "dax-error fallback");
+			goto fallback;
 		}
 		if (length < PMD_SIZE) {
 			dax_pmd_dbg(&bh, address, "dax-length too small");
-- 
2.5.5

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 0/7] dax: handling media errors Vishal Verma <vishal.l.verma@intel.com> - 2016-04-28 23:30 +0200
  [PATCH v4 2/7] dax: fallback from pmd to pte on error Vishal Verma <vishal.l.verma@intel.com> - 2016-04-28 23:30 +0200
  [PATCH v4 8/7] Documentation: add error handling information to dax.txt Vishal Verma <vishal.l.verma@intel.com> - 2016-04-30 00:00 +0200

csiph-web