Re: [PATCH 0/8] Replace kernel-defined ASYNC_ bits

Path	csiph.com!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Grant Edwards <grant.b.edwards@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/8] Replace kernel-defined ASYNC_ bits
Date	Thu, 28 Apr 2016 22:50:03 +0200
Message-ID	<rt12P-1W5-43@gated-at.bofh.it> (permalink)
References	<rmbTj-5cW-3@gated-at.bofh.it> <rt0T9-1Qs-17@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZGTgM4uId+RNxOpKX2n+zJMIC9SQhhIPVCz6z4fzFkw=; b=tOJ/RfebQYl5kuHf5n015A5yUyqBsetSycsohJDPyAj3chlbP5fuO0ef38W9RXtVBI LJGsSQDmu92sL1C83M80UMfVXFFvUbGOVAZRQ/eKu0+O6WOMh+8/OxAmc92ahvnvC/Bl 5JMG+C9IeV1Qi2VaNyEos5vyde3NxL7zJ3WL+YyXaCgXBN7RYMgHOxB+3WdjO6/iGZ2H ET6eD5sO2PXG0yiw5QakDRkk4JXl37Bec9vVYkHA/MkbOBNrvcETSa4A5t8YuDmFx0ld qdy9gq3ekdeWYZvuxPw+cWt0sqLj8qgq2y+PxMLA8ARP/NAZSqZyGNr2Km5mMgjJwm2y Ufig==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZGTgM4uId+RNxOpKX2n+zJMIC9SQhhIPVCz6z4fzFkw=; b=TK7Y7H3TryTvarlU7lX9xSHgl8THsv2VTe9Z+PpGDakaRDpwVeV0CVwfxoEQyPo+6x ZwDg0rugU7QZsETwGaL2OMfb9bbhCwb4E8zfV4WmsQFYd+MzE6H/FdiVVEDpbpLvvi4w GJv2e5hzWFaZivWsmy4KTWCJRuPlz4Rp9yvxi7NgiUYSariFNNUf+vO00stfT4+m236j soXM6lpkoTykjB27Rlh3+V+AqrZQp0UM+5uAlTHSPW8dCaneo+bJEFVISdilZqQIkYT8 zChwjXK7T9/0tSkuh5HTgNQ19kphEEiawqmL5g3o9FLPq+MLNUyTDmnY9L6MgQo7zGJs 4P1g==
X-Gm-Message-State	AOPr4FWcnYPXG6DfwRxLoZsFrIBKkrbrGgL/hfxVunIzqdf8cMaerVr7e2YzsRUhiOYoHA==
X-Received	by 10.50.36.36 with SMTP id n4mr20067715igj.67.1461876257538; Thu, 28 Apr 2016 13:44:17 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	Peter Hurley <peter@hurleysoftware.com>, Jiri Slaby <jslaby@suse.cz>, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
X-Original-Date	Thu, 28 Apr 2016 15:44:15 -0500
X-Original-Message-ID	<20160428204415.GA21183@grante>
X-Original-References	<1460249607-8014-1-git-send-email-peter@hurleysoftware.com> <20160428203643.GA13542@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1390518

Show key headers only | View raw

On Thu, Apr 28, 2016 at 01:36:43PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Apr 09, 2016 at 05:53:19PM -0700, Peter Hurley wrote:
> > As outlined in my January email ("RFC: out-of-tree tty driver breakage"),
> > the tty/serial core uses 5 bits in the tty_port.flags field to manage
> > state. They are:
[...]
> > The last patch of the series purposefully breaks out-of-tree driver
> > builds to ensure they update state test/change methods to the helpers
> > instead.
> > 
> > REQUIRES: "tty: Replace TTY_IO_ERROR bit tests with tty_io_error()"
> >           "tty: Replace TTY_THROTTLED bit tests with tty_throttled()"
> 
> Wonderful, thanks for doing this work.

And particular thanks from us out-of-tree driver maintainers for
making the breakage apparent.  It always sucks when a change goes in
under our radar that causes breakage without even causing a compiler
warning.  [Yea, I know if the drivers were in-tree, this wouldn't be a
problem.]

-- 
Grant

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/8] Replace kernel-defined ASYNC_ bits Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-28 22:40 +0200
  Re: [PATCH 0/8] Replace kernel-defined ASYNC_ bits Grant Edwards <grant.b.edwards@gmail.com> - 2016-04-28 22:50 +0200

csiph-web