Re: [Patch v2 1/8] dt/bindings: firmware: Add Qualcomm SCM binding

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [Patch v2 1/8] dt/bindings: firmware: Add Qualcomm SCM binding
Date	Thu, 28 Apr 2016 22:50:03 +0200
Message-ID	<rt12P-1W5-35@gated-at.bofh.it> (permalink)
References	<rrXND-5JB-3@gated-at.bofh.it> <rrXXj-5Np-7@gated-at.bofh.it> <rs0iu-7wL-11@gated-at.bofh.it> <rs0Lw-89e-17@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	66
Organization	linux.* mail to news gateway
X-Original-Cc	Stephen Boyd <sboyd@codeaurora.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jilai wang <jilaiw@codeaurora.org>
X-Original-Date	Thu, 28 Apr 2016 15:47:49 -0500
X-Original-Message-ID	<20160428204749.GA12941@rob-hp-laptop>
X-Original-References	<1461625725-32425-1-git-send-email-andy.gross@linaro.org> <1461625725-32425-2-git-send-email-andy.gross@linaro.org> <20160426014906.GH29990@codeaurora.org> <CAPBZ5QceWcTCTJSnp-OpoeK_YdV8DOWe+569+6yXpSWhR243Og@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1390514

Show key headers only | View raw

On Mon, Apr 25, 2016 at 09:14:59PM -0500, Andy Gross wrote:
> On 25 April 2016 at 20:49, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 04/25, Andy Gross wrote:
> >> This patch adds the device tree support for the Qualcomm SCM firmware.
> >>
> >> Signed-off-by: Andy Gross <andy.gross@linaro.org>
> >> ---
> >>  .../devicetree/bindings/firmware/qcom,scm.txt      | 28 ++++++++++++++++++++++
> >>  1 file changed, 28 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/firmware/qcom,scm.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> >> new file mode 100644
> >> index 0000000..a679a87
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> >> @@ -0,0 +1,28 @@
> >> +QCOM Secure Channel Manager (SCM)
> >> +
> >> +Qualcomm processors include an interface to communicate to the secure firmware.
> >> +This interface allows for clients to request different types of actions.  These
> >> +can include CPU power up/down, HDCP requests, loading of firmware, and other
> >> +assorted actions.
> >> +
> >> +Required properties:
> >> +- compatible: must contain one of the following:
> >> + * "qcom,scm-apq8064" for APQ8064
> >> + * "qcom,scm-apq8084" for APQ8084
> >> + * "qcom,scm-msm8916" for MSM8916
> >> + * "qcom,scm-msm8974" for MSM8974
> >
> > Do we need to keep adding these into the driver for every SoC
> > that we support? My understanding is apq8064 can be the one that
> > requires one clk, and msm8974 can be the one that requires three.
> > The driver can just have those two compatibles for now, and we
> > can keep adding compatibles here for the different SoCs, but
> > really we don't care, that's just to save ourselves if something
> > pops up and needs a workaround.
> >
> > It will certainly look weird if it's firmware that's compatible
> > with qcom,scm-msm8974 but on an apq8084, so perhaps something

Not if the first string has apq8084.

> > more generic like, qcom-scm-v1 and qcom,scm-v2 can be used as the
> > generic compatible in the driver:
> >
> >         compatible = "qcom,scm-apq8064", "qcom,scm-v1";
> >
> >         vs.
> >
> >         compatible = "qcom,scm-apq8084", "qcom,scm-v2";
> >
> > ?
> >
> > I just want to avoid the constant SoC churn update here if we can.
> 
> Right.  We can certainly do it that way.  Its just that the v1/v2
> aren't the real versions.  What if we did qcom,scm vs
> qcom,scm-apq8064?

I'd prefer this over fake version numbers.

Is there any sane versioning of the firmware itself that could be used?

Rob

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Patch v2 1/8] dt/bindings: firmware: Add Qualcomm SCM binding Rob Herring <robh@kernel.org> - 2016-04-28 22:50 +0200

csiph-web