Re: linux-next: build failure after merge of the block tree

From	Michal Marek <mmarek@suse.cz>
Newsgroups	linux.kernel
Subject	Re: linux-next: build failure after merge of the block tree
Date	2016-04-27 11:10 +0200
Message-ID	<rstDQ-779-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <rsbnA-9L-9@gated-at.bofh.it> <rsctk-Xx-25@gated-at.bofh.it> <rsctk-Xx-27@gated-at.bofh.it> <rscWl-1qW-17@gated-at.bofh.it> <rsi5H-5Mq-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016-04-26 22:48, Nicolas Pitre wrote:
> On Wed, 27 Apr 2016, Stephen Rothwell wrote:
> 
>> Hi Nicolas,
>>
>> On Tue, 26 Apr 2016 10:40:57 -0400 (EDT) Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
>>>
>>> If you can reproduce this build failure, could you try a make mrproper 
>>> and attempt it again?  I, too, would like to find an explanation and a 
>>> way to reproduce.
>>
>> I reset my build tree to commit 9d67df654092 ("Merge remote-tracking
>> branch 'block/for-next'") and the build failed with:
>>
>> ERROR: ".local_clock" [drivers/vhost/vhost_net.ko] undefined!
>> ERROR: ".local_clock" [drivers/misc/cxl/cxl.ko] undefined!
>>
>> :-(
>>
>> So I did a "make mrproper" and did the build again.
>>
>> That built correctly.
>>
> [...]
> 
> OK!  After digging and diffing through 750 megabytes of make debug logs 
> I finally found the explanation.  The if_changed directive is useless 
> against phony targets.
> 
> @Stephen: could you replace the revert with the patch below in your tree?
> 
> @Michal: could you fold the patch below into commit 2441e78b19 in your tree?

I prefer not to overwrite the topic branches unless necessary and I
wanted to credit Stephen, so I committed your patch with a fabricated
commit message and your signoff (since you wanted to fold it into a
patch that you had already signed off).

Michal

Thread

linux-next: build failure after merge of the block tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-26 05:40 +0200
  Re: linux-next: build failure after merge of the block tree Michal Marek <mmarek@suse.cz> - 2016-04-26 15:40 +0200
    Re: linux-next: build failure after merge of the block tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-26 16:00 +0200
    Re: linux-next: build failure after merge of the block tree Jens Axboe <axboe@kernel.dk> - 2016-04-26 16:50 +0200
    Re: linux-next: build failure after merge of the block tree Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-04-26 16:50 +0200
      Re: linux-next: build failure after merge of the block tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-26 17:20 +0200
        Re: linux-next: build failure after merge of the block tree Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-04-26 22:50 +0200
          Re: linux-next: build failure after merge of the block tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-26 23:40 +0200
          Re: linux-next: build failure after merge of the block tree Michal Marek <mmarek@suse.cz> - 2016-04-27 11:10 +0200
            Re: linux-next: build failure after merge of the block tree Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-04-27 15:50 +0200

csiph-web