Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1388752

Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

Show all headers | View raw

Hi,

On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote:
> @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
>  		xhci->shared_hcd->can_do_streams = 1;
>  
> +	hcd->phy = devm_phy_get(&pdev->dev, "usb2-phy");
> +	if (IS_ERR(hcd->phy)) {
> +		ret = PTR_ERR(hcd->phy);
> +		if (ret == -EPROBE_DEFER)
> +			goto put_usb3_hcd;
> +		hcd->phy = NULL;
> +	}
> +
> +	phy = devm_phy_get(&pdev->dev, "usb-phy");

"usb-phy" for what I understand is the USB3 PHY right?

I was unable to find any definition for the phy names for example from
Documentation/devicetree/bindings/usb/usb-xhci.txt, so I would say
this needs to be "usb3-phy" and the phy names need to be defined
somewhere.


Thanks,

-- 
heikki

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v2 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang <jszhang@marvell.com> - 2016-04-26 15:10 +0200
  [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Jisheng Zhang <jszhang@marvell.com> - 2016-04-26 15:10 +0200
    Re: [RESEND PATCH v2 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 07:40 +0200
  [RESEND PATCH v2 4/7] usb: xhci: plat: sort the headers in alphabetic order Jisheng Zhang <jszhang@marvell.com> - 2016-04-26 15:10 +0200
  [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Jisheng Zhang <jszhang@marvell.com> - 2016-04-26 15:10 +0200
    Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 07:40 +0200
      Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Jisheng Zhang <jszhang@marvell.com> - 2016-04-27 09:00 +0200
        Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 09:30 +0200
    Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-04-27 10:00 +0200
      Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 11:40 +0200
  [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Jisheng Zhang <jszhang@marvell.com> - 2016-04-26 15:10 +0200
    Re: [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 07:40 +0200
      Re: [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to  the correct hcd Jisheng Zhang <jszhang@marvell.com> - 2016-04-27 08:10 +0200
        Re: [RESEND PATCH v2 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 08:30 +0200
  [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Jisheng Zhang <jszhang@marvell.com> - 2016-04-26 15:10 +0200
    Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 07:40 +0200
      Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Mark Brown <broonie@kernel.org> - 2016-04-27 12:00 +0200
        Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator  control Jisheng Zhang <jszhang@marvell.com> - 2016-04-27 12:30 +0200
          Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Mark Brown <broonie@kernel.org> - 2016-04-27 15:30 +0200
        Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 12:30 +0200
          Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Mark Brown <broonie@kernel.org> - 2016-04-27 12:40 +0200
            Re: [RESEND PATCH v2 7/7] usb: xhci: plat: add vbus regulator control Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 12:50 +0200

csiph-web