Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1388719

Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

From Nicolas Dichtel <nicolas.dichtel@6wind.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit
Date 2016-04-27 09:30 +0200
Message-ID <rss54-5GG-7@gated-at.bofh.it> (permalink)
References <rqLvc-49a-5@gated-at.bofh.it> <rqLve-49a-67@gated-at.bofh.it> <rsmj0-T5-3@gated-at.bofh.it>
Organization 6WIND

Show all headers | View raw

Le 27/04/2016 03:14, Balbir Singh a écrit :
> 
> 
> On 23/04/16 01:31, Nicolas Dichtel wrote:
>> Goal of this patch is to use the new libnl API to align netlink attribute
>> when needed.
>> The layout of the netlink message will be a bit different after the patch,
>> because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested
>> attribute instead of before it.
>>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> 
> The layout will change/break user space -- I've not tested the patch though..
Sigh.

I quote David:
"All userspace components using netlink should always ignore attributes
they do not recognize in dumps.

This is one of the most basic principles of netlink"

Do you have some pointers so I can made some tests?


Regards,
Nicolas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/9] netlink: align attributes when needed (patchset #1) Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 3/9] libnl: nla_put_be64(): align on a 64-bit area Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 7/9] libnl: add nla_put_u64_64bit() helper Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 1/9] libnl: fix help of _64bit functions Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
    Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit  area Eric Dumazet <eric.dumazet@gmail.com> - 2016-04-22 19:00 +0200
      Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit  area Alexander Aring <aar@pengutronix.de> - 2016-04-23 19:10 +0200
        Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit  area Alexander Aring <aar@pengutronix.de> - 2016-04-23 19:30 +0200
          Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit  area Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-25 09:50 +0200
  [PATCH net-next 6/9] libnl: nla_put_msecs(): align on a 64-bit area Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 8/9] xfrm: align nlattr properly when needed Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 5/9] libnl: nla_put_s64(): align on a 64-bit area Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 4/9] libnl: nla_put_net64(): align on a 64-bit area Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
  [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-22 17:50 +0200
    Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr  on 64-bit Balbir Singh <bsingharora@gmail.com> - 2016-04-27 03:20 +0200
      Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr  on 64-bit Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-27 09:30 +0200
        Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr  on 64-bit Balbir Singh <bsingharora@gmail.com> - 2016-04-27 14:30 +0200
          Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr  on 64-bit Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-27 17:50 +0200
            [PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-27 17:50 +0200
              Re: [PATCH net-next] taskstats: fix nl parsing in  accounting/getdelays.c Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-27 18:00 +0200
          Re: [PATCH net-next 9/9] taskstats: use the libnl API to align  nlattr on 64-bit David Miller <davem@davemloft.net> - 2016-04-27 18:50 +0200
  Re: [PATCH net-next 0/9] netlink: align attributes when needed  (patchset #1) David Miller <davem@davemloft.net> - 2016-04-24 02:20 +0200

csiph-web