Re: [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path

From	Felipe Balbi <felipe.balbi@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path
Date	2016-04-27 09:30 +0200
Message-ID	<rss54-5GG-5@gated-at.bofh.it> (permalink)
References	<rsaUy-8ny-5@gated-at.bofh.it> <rsaUz-8ny-21@gated-at.bofh.it> <rsqmC-42B-5@gated-at.bofh.it> <rsriF-4Tl-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Jisheng Zhang <jszhang@marvell.com> writes:
> Dear Felipe,
>
> On Wed, 27 Apr 2016 08:33:52 +0300 Felipe Balbi wrote:
>
>> Jisheng Zhang <jszhang@marvell.com> writes:
>> > Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to
>> > clk_{unprepare, disable}()") allows NULL or error pointer to be passed
>> > unconditionally.
>> >
>> > This patch is to simplify probe error and remove code paths.  
>> 
>> this seems wrong to me. xhci->clk isn't initialized to NULL, it's either
>> initialized to a valid struct clk * or some ERR_PTR() value.
>
> Commit 63589e92c2d9 could also ignore error value ;)

oh okay, thanks for that. That's, IMHO, quite dangerous ;-)

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Jisheng Zhang <jszhang@marvell.com> - 2016-04-26 15:10 +0200
  Re: [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 07:40 +0200
    Re: [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for  optional clock in error/remove path Jisheng Zhang <jszhang@marvell.com> - 2016-04-27 08:40 +0200
      Re: [RESEND PATCH v2 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-04-27 09:30 +0200

csiph-web