Re: [PATCH 2/2] bfp tools: Fix syscall argument

From	"Wangnan (F)" <wangnan0@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] bfp tools: Fix syscall argument
Date	2016-04-27 05:10 +0200
Message-ID	<rso1s-2jQ-3@gated-at.bofh.it> (permalink)
References	<rrEBk-6GB-15@gated-at.bofh.it> <rrEBk-6GB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016/4/25 10:34, Florian Fainelli wrote:
> Coverity flagged this under CID 1354884 as a sizeof mismatch, it turns
> out that the argument "attr" passed to syscall should have been a
> pointer to attr in the first place.
>
> Reported-by: coverity (CID 1354884)
> Fixes: 8f9e05fb298f ("perf tools: Fix PowerPC native building")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>   tools/build/feature/test-bpf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/build/feature/test-bpf.c b/tools/build/feature/test-bpf.c
> index 8236df9a46ca..e04ab89a1013 100644
> --- a/tools/build/feature/test-bpf.c
> +++ b/tools/build/feature/test-bpf.c
> @@ -31,5 +31,5 @@ int main(void)
>   	 * Test existence of __NR_bpf and BPF_PROG_LOAD.
>   	 * This call should fail if we run the testcase.
>   	 */
> -	return syscall(__NR_bpf, BPF_PROG_LOAD, attr, sizeof(attr));
> +	return syscall(__NR_bpf, BPF_PROG_LOAD, &attr, sizeof(attr));
>   }
Acked-by: Wang Nan <wangnan0@huawei.com>

Thread

[PATCH 0/2] bfp tools: Couple Coverity fixes Florian Fainelli <f.fainelli@gmail.com> - 2016-04-25 04:40 +0200
  [PATCH 1/2] bfp tools: Remove expression with no effect Florian Fainelli <f.fainelli@gmail.com> - 2016-04-25 04:40 +0200
    Re: [PATCH 1/2] bfp tools: Remove expression with no effect "Wangnan (F)" <wangnan0@huawei.com> - 2016-04-27 05:20 +0200
      Re: [PATCH 1/2] bfp tools: Remove expression with no effect Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-04-27 16:40 +0200
  [PATCH 2/2] bfp tools: Fix syscall argument Florian Fainelli <f.fainelli@gmail.com> - 2016-04-25 04:40 +0200
    Re: [PATCH 2/2] bfp tools: Fix syscall argument "Wangnan (F)" <wangnan0@huawei.com> - 2016-04-27 05:10 +0200
      Re: [PATCH 2/2] bfp tools: Fix syscall argument Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-04-27 16:40 +0200
  Re: [PATCH 0/2] bfp tools: Couple Coverity fixes Florian Fainelli <f.fainelli@gmail.com> - 2016-04-27 04:50 +0200
    Re: [PATCH 0/2] bfp tools: Couple Coverity fixes "Wangnan (F)" <wangnan0@huawei.com> - 2016-04-27 05:10 +0200
      Re: [PATCH 0/2] bfp tools: Couple Coverity fixes Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-04-27 05:10 +0200
        Re: [PATCH 0/2] bfp tools: Couple Coverity fixes Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-04-27 16:30 +0200

csiph-web