Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic
Date	2016-04-27 02:40 +0200
Message-ID	<rslGk-kK-57@gated-at.bofh.it> (permalink)
References	<rqlhn-8vU-5@gated-at.bofh.it> <rqlho-8vU-11@gated-at.bofh.it> <rqWJX-4Ka-1@gated-at.bofh.it> <rsc9Y-OI-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (04/26/16 16:21), Petr Mladek wrote:
[..]
> > move printk_nmi_flush_on_panic() to printk.c, and place it next to
> > printk_flush_on_panic() (so we will have two printk "flush-on-panic"
> > functions sitting together). /* printk_nmi_flush() is in printk.h,
> > so it's visible to printk anyway */
> > 
> > it also will let us keep logbuf_lock static, it's a bit too internal
> > to printk to expose it, I think.
> > 
> > IOW, something like this?
> 
> It is rather cosmetic change. I 

oh yes, it is. just to keep similar functionality (flush, zap locks)
in one place (printk).

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic Petr Mladek <pmladek@suse.com> - 2016-04-21 13:50 +0200
  Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-23 05:50 +0200
    Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic Petr Mladek <pmladek@suse.com> - 2016-04-26 16:30 +0200
      Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-04-27 02:40 +0200

csiph-web