Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs

From	Peter Griffin <peter.griffin@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs
Date	2016-04-26 19:50 +0200
Message-ID	<rsfhw-3db-27@gated-at.bofh.it> (permalink)
References	(4 earlier) <rsc9X-OI-13@gated-at.bofh.it> <rscD0-11Z-35@gated-at.bofh.it> <rscMH-1n6-33@gated-at.bofh.it> <rsdSr-2bx-29@gated-at.bofh.it> <rsels-2qW-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mark,

On Tue, 26 Apr 2016, Mark Brown wrote:

> On Tue, Apr 26, 2016 at 05:14:32PM +0100, Peter Griffin wrote:
> > On Tue, 26 Apr 2016, Mark Brown wrote:
> 
> > > A lot of this is details of the system integration for this SoC, not
> > > actual errors.
> 
> > This particular clock patch yes, but the other ASoC dt doc update is fixing
> > bindings which haven't progressed in lockstep with the driver code. Presumably
> > this happened during the review process when they were changed to being st,
> > prefixed in the driver, but the doc wasn't also updated.
> 
> The bits where you are correcting the names of the properties are not
> details of the system integration and are therefore fine.  The bits
> where you're documenting the particular clocking arrangements for the
> SoC you happen to be using less so.

Ok sounds good. With that in mind I will drop this clocking patch in v4
and just leave the one which updates the ASoC bindings mismatch.

> 
> > > it's fairly routine
> > > to have to explain to people that just because some old driver did
> > > something that doesn't mean it's something we want in new drivers.
> 
> > I'm sure it is. Although I fail to see why leaving the documentation with
> > mistakes in is helpful to anybody.
> 
> Fixing actual mistakes is fine.

Peter.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 10/18] ASoC: sti: Update example to include assigned-clocks and mclk-fs Peter Griffin <peter.griffin@linaro.org> - 2016-04-21 13:10 +0200
  Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Mark Brown <broonie@kernel.org> - 2016-04-21 18:00 +0200
    Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Peter Griffin <peter.griffin@linaro.org> - 2016-04-26 14:00 +0200
      Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Mark Brown <broonie@kernel.org> - 2016-04-26 16:30 +0200
        Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Peter Griffin <peter.griffin@linaro.org> - 2016-04-26 17:00 +0200
          Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Mark Brown <broonie@kernel.org> - 2016-04-26 17:10 +0200
            Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Peter Griffin <peter.griffin@linaro.org> - 2016-04-26 18:20 +0200
              Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Mark Brown <broonie@kernel.org> - 2016-04-26 18:50 +0200
                Re: [PATCH 10/18] ASoC: sti: Update example to include  assigned-clocks and mclk-fs Peter Griffin <peter.griffin@linaro.org> - 2016-04-26 19:50 +0200

csiph-web