Re: [PATCH v3 1/5] dmaengine: mv_xor: make the code 64 bits compliant

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/5] dmaengine: mv_xor: make the code 64 bits compliant
Date	2016-04-26 18:30 +0200
Message-ID	<rse27-2io-35@gated-at.bofh.it> (permalink)
References	<rnSMx-51D-1@gated-at.bofh.it> <rnSMy-51D-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Apr 14, 2016 at 06:53:34PM +0200, Gregory CLEMENT wrote:
> Fix two warnings which appear when building for 64 bits target.

It is a good practice to post the warnings in log so that people know what
is being fixed

> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/dma/mv_xor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 3922a5d56806..a6ec82776cbc 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -477,7 +477,7 @@ mv_xor_prep_dma_xor(struct dma_chan *chan, dma_addr_t dest, dma_addr_t *src,
>  	BUG_ON(len > MV_XOR_MAX_BYTE_COUNT);
>  
>  	dev_dbg(mv_chan_to_devp(mv_chan),
> -		"%s src_cnt: %d len: %u dest %pad flags: %ld\n",
> +		"%s src_cnt: %d len: %zu dest %pad flags: %ld\n",
>  		__func__, src_cnt, len, &dest, flags);
>  
>  	sw_desc = mv_chan_alloc_slot(mv_chan);
> @@ -1220,7 +1220,7 @@ static int mv_xor_probe(struct platform_device *pdev)
>  			struct mv_xor_chan *chan;
>  			dma_cap_mask_t cap_mask;
>  			int irq;
> -			op_in_desc = (int)of_id->data;
> +			op_in_desc = (uintptr_t)of_id->data;
>  
>  			if (i >= max_channels)
>  				continue;
> -- 
> 2.5.0
> 

-- 
~Vinod

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/5] dmaengine: mv_xor: make the code 64 bits compliant Vinod Koul <vinod.koul@intel.com> - 2016-04-26 18:30 +0200

csiph-web