Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1387676
| From | Ville Syrjälä <ville.syrjala@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC v2 5/8] drm/fence: add in-fences support |
| Date | 2016-04-26 18:30 +0200 |
| Message-ID | <rse26-2io-7@gated-at.bofh.it> (permalink) |
| References | <rrXkB-57R-3@gated-at.bofh.it> <rrXkB-57R-1@gated-at.bofh.it> <rs8g2-5TZ-33@gated-at.bofh.it> <rsc0h-K8-5@gated-at.bofh.it> <rscjD-TC-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Apr 26, 2016 at 04:36:36PM +0200, Daniel Vetter wrote:
> On Tue, Apr 26, 2016 at 11:14:22AM -0300, Gustavo Padovan wrote:
> > 2016-04-26 Ville Syrjälä <ville.syrjala@linux.intel.com>:
> >
> > > On Mon, Apr 25, 2016 at 07:33:25PM -0300, Gustavo Padovan wrote:
> > > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > > >
> > > > There is now a new property called FENCE_FD attached to every plane
> > > > state that receives the sync_file fd from userspace via the atomic commit
> > > > IOCTL.
> > >
> > > I still don't like this property abuse. Also with atomic, all passed
> > > fences must be waited upon before anything is done, so attaching them
> > > to planes seems like it might just give people the wrong idea.
> >
> > I'm actually fine with this as property, but another solutions is use
> > an array of {plane, fence_fd} and extend drm_atomic_ioctl args just like
> > we have done for out fences. However the FENCE_FD property is easier to
> > handle in userspace than the array. Any other idea?
>
> Imo FENCE_FD is perfectly fine. But what's the concern around giving
> people the wrong idea with attaching fences to planes? For nonblocking
> commits we need to store them somewhere for the worker, drm_plane_state
> seems like an as good place as any other.
It gives the impression that each plane might flip as soon as its fence
signals.
--
Ville Syrjälä
Intel OTC
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC v2 5/8] drm/fence: add in-fences support Gustavo Padovan <gustavo@padovan.org> - 2016-04-26 00:40 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-04-26 12:20 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Gustavo Padovan <gustavo.padovan@collabora.co.uk> - 2016-04-26 16:20 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Daniel Vetter <daniel@ffwll.ch> - 2016-04-26 16:40 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-04-26 18:30 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Daniel Vetter <daniel@ffwll.ch> - 2016-04-26 19:30 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-04-26 19:50 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Daniel Vetter <daniel@ffwll.ch> - 2016-04-26 20:30 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-04-26 21:00 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Daniel Vetter <daniel@ffwll.ch> - 2016-04-26 22:10 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Greg Hackmann <ghackmann@google.com> - 2016-04-26 22:50 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Daniel Vetter <daniel@ffwll.ch> - 2016-04-27 08:40 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Daniel Stone <daniel@fooishbar.org> - 2016-04-27 09:00 +0200
Re: [RFC v2 5/8] drm/fence: add in-fences support Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-04-26 18:30 +0200
csiph-web