Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1387647

Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI)

Show all headers | View raw

Hi Sudeep,

On 4/19/2016 6:30 AM, Sudeep Holla wrote:
> +struct acpi_processor_lpi *lpi;
> +int acpi_processor_ffh_lpi_enter(struct acpi_processor_lpi *lpi, int idx)
> +{
> +	int ret;
> +
> +	if (!idx) {
> +		cpu_do_idle();
> +		return idx;
> +	}
> +
> +	/* TODO cpu_pm_{enter,exit} can be done in generic code ? */
> +	ret = cpu_pm_enter();
Can we avoid calling cpu_pm_enter and cpu_pm_exit for retention states as it is not necessary?
May be we can check LPI architecture specific context loss flags prior to calling these.
> +	if (!ret) {
> +		/*
> +		 * Pass idle state index to cpu_suspend which in turn will
> +		 * call the CPU ops suspend protocol with idle index as a
> +		 * parameter.
> +		 */
> +		ret = arm_cpuidle_suspend(idx);
> +
> +		cpu_pm_exit();
same here
> +	}
> +
> +	return ret ? -1 : idx;
> +}
> +

By the way, thanks for posting these patches!

-Prashanth

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla <sudeep.holla@arm.com> - 2016-04-19 14:40 +0200
  Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) kbuild test robot <lkp@intel.com> - 2016-04-19 16:10 +0200
    Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla <sudeep.holla@arm.com> - 2016-04-19 17:50 +0200
  Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) Vikas Sajjan <sajjan.linux@gmail.com> - 2016-04-20 12:10 +0200
    Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla <sudeep.holla@arm.com> - 2016-04-20 12:30 +0200
  Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) Jisheng Zhang <jszhang@marvell.com> - 2016-04-20 12:50 +0200
  Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) "Prakash, Prashanth" <pprakash@codeaurora.org> - 2016-04-26 18:00 +0200
    Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla <sudeep.holla@arm.com> - 2016-04-26 18:10 +0200

csiph-web