Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1387634
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier |
| Date | 2016-04-26 17:50 +0200 |
| Message-ID | <rsdpn-1Gb-1@gated-at.bofh.it> (permalink) |
| References | <rrV98-3ni-13@gated-at.bofh.it> <rrV98-3ni-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, Apr 25, 2016 at 03:17:36PM -0500, Andreas Dannenberg wrote:
This looks mostly good, a few small things below.
> + switch (width) {
> + case 16:
> + case 18:
> + case 20:
> + case 24:
> + /*
> + * We only support the different left-justified serial audio
> + * formats in which case there is nothing to configure in the
> + * TAS5720.
> + */
> + break;
> + default:
> + dev_err(codec->dev, "unsupported sample size: %d\n", width);
> + return -EINVAL;
> + }
If the driver doesn't do anything just remove the code.
> + if ((curr_fault & TAS5720_OCE) && !(tas5720->last_fault & TAS5720_OCE))
> + dev_warn(dev, "The Class-D output stage has experienced an over current event\n");
"Class D over current". The verbosity is making the line over long and
the phrasing is a bit unclear (and makes it seem less critical than it
really is). These should probably be dev_crit() or somthing too, over
current and similar events on a speaker output are generally extremely
serious.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg <dannenberg@ti.com> - 2016-04-25 22:20 +0200
Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Mark Brown <broonie@kernel.org> - 2016-04-26 17:50 +0200
Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg <dannenberg@ti.com> - 2016-04-26 18:30 +0200
Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Mark Brown <broonie@kernel.org> - 2016-04-26 19:40 +0200
Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg <dannenberg@ti.com> - 2016-04-26 20:10 +0200
Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier "Andrew F. Davis" <afd@ti.com> - 2016-04-26 19:30 +0200
Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg <dannenberg@ti.com> - 2016-04-26 19:40 +0200
csiph-web