Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration

From	Jarkko Nikula <jarkko.nikula@bitmer.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration
Date	2016-04-26 15:50 +0200
Message-ID	<rsbxh-eJ-23@gated-at.bofh.it> (permalink)
References	<rsbxh-eJ-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <jim.lodes@garmin.com>
> 
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
> 
> Signed-off-by: Jim Lodes <jim.lodes@garmin.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com>
> ---
>  sound/soc/omap/omap-pcm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
>  	struct dma_chan *chan;
>  	int err = 0;
>  
> +	memset(&config, 0x00, sizeof(config));

Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")

Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration Jarkko Nikula <jarkko.nikula@bitmer.com> - 2016-04-26 15:50 +0200

csiph-web