Re: [PATCH 2/5] perf tools: Extract __perf_evlist__mmap_read()

Path	csiph.com!news.mixmin.net!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] perf tools: Extract __perf_evlist__mmap_read()
Date	Tue, 26 Apr 2016 15:40:02 +0200
Message-ID	<rsbnA-9L-5@gated-at.bofh.it> (permalink)
References	<rs14R-8ie-3@gated-at.bofh.it> <rs14S-8ie-17@gated-at.bofh.it>
X-Original-To	Wang Nan <wangnan0@huawei.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-URL	http://acmel.wordpress.com
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	74
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Zefan Li <lizefan@huawei.com>, pi3orama@163.com
X-Original-Date	Tue, 26 Apr 2016 10:30:20 -0300
X-Original-Message-ID	<20160426133019.GF16708@kernel.org>
X-Original-References	<1461637738-62722-1-git-send-email-wangnan0@huawei.com> <1461637738-62722-3-git-send-email-wangnan0@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1387474

Show key headers only | View raw

Em Tue, Apr 26, 2016 at 02:28:55AM +0000, Wang Nan escreveu:
> Extract event reader to __perf_evlist__mmap_read(). Future commit will
> feed it with manually computed 'head' and 'old' pointers.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Zefan Li <lizefan@huawei.com>
> Cc: pi3orama@163.com
> ---
>  tools/perf/util/evlist.c | 40 +++++++++++++++++++++++++---------------
>  1 file changed, 25 insertions(+), 15 deletions(-)
> 
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 85271e5..3ee94b2 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -679,24 +679,15 @@ static struct perf_evsel *perf_evlist__event2evsel(struct perf_evlist *evlist,
>  	return NULL;
>  }
>  
> -union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)
> +static union perf_event *
> +__perf_evlist__mmap_read(struct perf_mmap *md, bool overwrite, u64 head,
> +			 u64 old, u64 *prev)
>  {

Ok, now this is not a perf_evlist method anymore, see the first
parameter? It handles perf_mmap instances, so please rename it to:

static union perf_event *perf_mmap__read(struct perf_mmap *md, bool overwrite,
					 u64 head, u64 *prev)

And thanks for leaving the renaming of those variables to the next
patch, that eases reviewieng indeed.

> -	struct perf_mmap *md = &evlist->mmap[idx];
> -	u64 head;
> -	u64 old = md->prev;
>  
> +union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)
> +{
> +	struct perf_mmap *md = &evlist->mmap[idx];
> +	u64 head;
> +	u64 old = md->prev;
> +
> +	if (!atomic_read(&md->refcnt))
> +		return NULL;
> +
> +	head = perf_mmap__read_head(md);
> +
> +	return __perf_evlist__mmap_read(md, evlist->overwrite, head,
> +					old, &md->prev);


See that perf_mmap__read_head()? It acts on a struct perf_mmap too, thus
the prefix. This will end up as:

	head = perf_mmap__read_head(md);

	return perf_mmap__read(md, evlist->overwrite, head, old, &md->prev);

And see below yet another perf_mmap method, perf_mmap__empty()

Regards,

- Arnaldo
> +}
> +
>  static bool perf_mmap__empty(struct perf_mmap *md)
>  {
>  	return perf_mmap__read_head(md) == md->prev && !md->auxtrace_mmap.base;
> -- 
> 1.8.3.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] perf tools: Extract __perf_evlist__mmap_read() Wang Nan <wangnan0@huawei.com> - 2016-04-26 04:40 +0200
  Re: [PATCH 2/5] perf tools: Extract __perf_evlist__mmap_read() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-26 15:40 +0200

csiph-web