Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1387425

Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit()

Show all headers | View raw

On Tue 26-04-16 14:31:58, Nicolas Dichtel wrote:
> Le 26/04/2016 13:08, Jan Kara a écrit :
> > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> > 
> > OK, so I somewhat miss a description of what will this do to the netlink
> > message so that I can judge whether the change is fine for the userspace
> > counterpart parsing these messages. AFAIU this changes the message format
> > by adding a QUOTA_NL_A_PAD field before each 64-bit field which needs an
> > alignment, am I guessing right? Thus when the userspace counterpart uses
> > genlmsg_parse() it should just silently ignore these attributes if I read
> > the documentation right. Did I understand this correctly?
> Yes, that's it.

OK, then feel free to add:

Acked-by: Jan Kara <jack@suse.cz>

to the quota patch.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:10 +0200
  [PATCH net-next 1/8] macsec: use nla_put_u64_64bit() Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:10 +0200
  [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:10 +0200
    Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() Jan Kara <jack@suse.cz> - 2016-04-26 13:10 +0200
      Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() Jan Kara <jack@suse.cz> - 2016-04-26 14:40 +0200
      Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 14:40 +0200
      Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit() David Miller <davem@davemloft.net> - 2016-04-26 18:30 +0200
  [PATCH net-next 5/8] ovs: align nlattr properly when needed Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:10 +0200
  [PATCH net-next 8/8] sched: align nlattr properly when needed Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:10 +0200
  [PATCH net-next 7/8] neigh: align nlattr properly when needed Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:10 +0200
  [PATCH net-next 2/8] drivers/wireless: use nla_put_u64_64bit() Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:20 +0200
  [PATCH net-next 4/8] sock_diag: align nlattr properly when needed Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-04-26 10:20 +0200
  Re: [PATCH net-next 0/8] netlink: align attributes when needed  (patchset #3) Lars Ellenberg <lars.ellenberg@linbit.com> - 2016-04-26 14:00 +0200
    Re: [Drbd-dev] [PATCH net-next 0/8] netlink: align attributes when  needed (patchset #3) Lars Ellenberg <lars.ellenberg@linbit.com> - 2016-04-26 14:20 +0200
    Re: [PATCH net-next 0/8] netlink: align attributes when needed  (patchset #3) David Miller <davem@davemloft.net> - 2016-04-26 18:30 +0200
  Re: [PATCH net-next 0/8] netlink: align attributes when needed  (patchset #3) David Miller <davem@davemloft.net> - 2016-04-26 18:10 +0200

csiph-web