Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390213

[PATCH v2 08/13] staging/android: improve documentation for sync_file

Show all headers | View raw

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

num_fences was missing a colon mark and sync_file_create() now have
better description.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/staging/android/sync_file.c | 5 +++--
 drivers/staging/android/sync_file.h | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/sync_file.c b/drivers/staging/android/sync_file.c
index 2c724ec..d9da3a4 100644
--- a/drivers/staging/android/sync_file.c
+++ b/drivers/staging/android/sync_file.c
@@ -65,11 +65,12 @@ static void fence_check_cb_func(struct fence *f, struct fence_cb *cb)
 }
 
 /**
- * sync_fence_create() - creates a sync fence
+ * sync_file_create() - creates a sync file
  * @fence:	fence to add to the sync_fence
  *
  * Creates a sync_file containg @fence. Once this is called, the sync_file
- * takes ownership of @fence.
+ * takes ownership of @fence. The sync_file can be released with
+ * fput(sync_file->file). Returns the sync_file or NULL in case of error.
  */
 struct sync_file *sync_file_create(struct fence *fence)
 {
diff --git a/drivers/staging/android/sync_file.h b/drivers/staging/android/sync_file.h
index 8a1b546..c6ffe8b 100644
--- a/drivers/staging/android/sync_file.h
+++ b/drivers/staging/android/sync_file.h
@@ -32,7 +32,7 @@ struct sync_file_cb {
  * @kref:		reference count on fence.
  * @name:		name of sync_file.  Useful for debugging
  * @sync_file_list:	membership in global file list
- * @num_fences		number of sync_pts in the fence
+ * @num_fences:		number of sync_pts in the fence
  * @wq:			wait queue for fence signaling
  * @status:		0: signaled, >0:active, <0: error
  * @cbs:		sync_pts callback information
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/13] De-stage Sync File Framework Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 06/13] staging/android: remove name arg from sync_file_create() Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 08/13] staging/android: improve documentation for sync_file Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 11/13] dma-buf/sync_file: de-stage sync_file Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 04/13] staging/android: make sync_file_merge() static Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 07/13] staging/android: prepare sync_file for de-staging Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 12/13] Documentation: include sync_file into DocBook Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 02/13] staging/android: drop sync_file_install() and sync_file_put() Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 09/13] staging/android: style fix: alignment to match the open parenthesis Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 13/13] Documentation: add Sync File doc Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 15:50 +0200
  [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 16:00 +0200
  [PATCH v2 03/13] staging/android: move sync_file functions comments to sync.c Gustavo Padovan <gustavo@padovan.org> - 2016-04-28 16:00 +0200
  Re: [PATCH v2 00/13] De-stage Sync File Framework Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-30 02:40 +0200

csiph-web