Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1390209

Re: [PATCH 2/3] lightnvm: enable metadata to be sent to device

From Matias Bjørling <mb@lightnvm.io>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] lightnvm: enable metadata to be sent to device
Date 2016-04-28 15:50 +0200
Message-ID <rsUul-3Xq-9@gated-at.bofh.it> (permalink)
References <rsBrI-4Yl-3@gated-at.bofh.it> <rsBrH-4Yl-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04/27/2016 07:28 PM, Javier González wrote:
> Enable metadata to be sent to the device through the metadata field on
> the physical rw nvme command. When a single ppa is sent to the device, a
> 64-bit integer can be sent as metadata; when a ppa list is sent, a
> 64-bit integer list mapping to the ppa list can be used to send
> metadata.
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
>   drivers/nvme/host/lightnvm.c | 1 +
>   include/linux/lightnvm.h     | 4 ++--
>   2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index b1a0d8b..92da28d 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -467,6 +467,7 @@ static inline void nvme_nvm_rqtocmd(struct request *rq, struct nvm_rq *rqd,
>   	c->ph_rw.opcode = rqd->opcode;
>   	c->ph_rw.nsid = cpu_to_le32(ns->ns_id);
>   	c->ph_rw.spba = cpu_to_le64(rqd->ppa_addr.ppa);
> +	c->ph_rw.metadata = cpu_to_le64(rqd->meta_list);
>   	c->ph_rw.control = cpu_to_le16(rqd->flags);
>   	c->ph_rw.length = cpu_to_le16(rqd->nr_pages - 1);
>
> diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
> index 1e3b53e..9768bae 100644
> --- a/include/linux/lightnvm.h
> +++ b/include/linux/lightnvm.h
> @@ -239,8 +239,8 @@ struct nvm_rq {
>
>   	struct ppa_addr *ppa_list;
>
> -	void *metadata;
> -	dma_addr_t dma_metadata;
> +	void *meta_list;
> +	dma_addr_t dma_meta_list;
>
>   	struct completion *wait;
>   	nvm_end_io_fn *end_io;
>

Thanks Javier. Applied for 4.7.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] lightnvm: enable metadata to be sent to device "Javier González" <jg@lightnvm.io> - 2016-04-27 19:30 +0200
  Re: [PATCH 2/3] lightnvm: enable metadata to be sent to device Matias Bjørling <mb@lightnvm.io> - 2016-04-28 15:50 +0200

csiph-web