[PATCH 16/20] unicore32: get rid of superfluous __GFP_REPEAT

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 16/20] unicore32: get rid of superfluous __GFP_REPEAT
Date	Thu, 28 Apr 2016 15:30:04 +0200
Message-ID	<rsUb2-3LP-65@gated-at.bofh.it> (permalink)
References	<rsUaZ-3LP-3@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1boi/JDYgBISAoqFo3RIUHO+2G4tyoAclPWq4GLpqJ8=; b=Z3sj7qCm9iuhVZuxHjPlklFOalIYGMlXATUCf11kfpVieWB5gNtoEllY6z42HFvBPt nfK8qdaGH+5mLuNJmI4H36angeWEzqHm2AavICxUT1TCWZfEIhEp6SpzVf8A/Dcosz59 StR+dWRdImUVgH8MSicSucoFF4FRiY9YDZDSdWWZA2oOAVFM7FElE+1W6zGNA9oZde8l VPaOFmS9RD6ZtyWoedVxN24B/CSt57BcfEYzhqdf+6k719oLFQfIB8FWi040vhYssjKb 1/iE+SSp2kwfu2s7K6davrBoiuxGIKh2V7HwXiUPaALHficI7Jz8RT9+1PbdtFmGlaUg CmBw==
X-Gm-Message-State	AOPr4FXbW5KFGbWXsISYCFMFCYEaZwxzCgbAcU6EQGpxZAl9MfqXqYrATj+LZ54MR1792A==
X-Received	by 10.194.87.103 with SMTP id w7mr15574686wjz.13.1461849864423; Thu, 28 Apr 2016 06:24:24 -0700 (PDT)
X-Mailer	git-send-email 2.8.0.rc3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, linux-arch@vger.kernel.org
X-Original-Date	Thu, 28 Apr 2016 15:24:02 +0200
X-Original-Message-ID	<1461849846-27209-17-git-send-email-mhocko@kernel.org>
X-Original-References	<1461849846-27209-1-git-send-email-mhocko@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1390185

Show key headers only | View raw

From: Michal Hocko <mhocko@suse.com>

__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.

PGALLOC_GFP uses __GFP_REPEAT but it is only used in pte_alloc_one,
pte_alloc_one_kernel which does order-0 request.  This means that this
flag has never been actually useful here because it has always been used
only for PAGE_ALLOC_COSTLY requests.

Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: linux-arch@vger.kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/unicore32/include/asm/pgalloc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/unicore32/include/asm/pgalloc.h b/arch/unicore32/include/asm/pgalloc.h
index 2e02d1356fdf..26775793c204 100644
--- a/arch/unicore32/include/asm/pgalloc.h
+++ b/arch/unicore32/include/asm/pgalloc.h
@@ -28,7 +28,7 @@ extern void free_pgd_slow(struct mm_struct *mm, pgd_t *pgd);
 #define pgd_alloc(mm)			get_pgd_slow(mm)
 #define pgd_free(mm, pgd)		free_pgd_slow(mm, pgd)
 
-#define PGALLOC_GFP	(GFP_KERNEL | __GFP_NOTRACK | __GFP_REPEAT | __GFP_ZERO)
+#define PGALLOC_GFP	(GFP_KERNEL | __GFP_NOTRACK | __GFP_ZERO)
 
 /*
  * Allocate one PTE table.
-- 
2.8.0.rc3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 16/20] unicore32: get rid of superfluous __GFP_REPEAT Michal Hocko <mhocko@kernel.org> - 2016-04-28 15:30 +0200

csiph-web