Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1390182

[PATCH 09/20] parisc: get rid of superfluous __GFP_REPEAT

Path csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 09/20] parisc: get rid of superfluous __GFP_REPEAT
Date Thu, 28 Apr 2016 15:30:04 +0200
Message-ID <rsUb2-3LP-55@gated-at.bofh.it> (permalink)
References <rsUaZ-3LP-3@gated-at.bofh.it>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/zIqtlhYhHFtgfO9/186g+xl6y/Tu7P2iWGn20G4ikM=; b=DRgtehinTTvaq//iGZKmgyejuZQOPzcKG2CWE3ih2uoUZvWPay+9z4miF4Bcp+iZKc fEdJgmSOh0Nfqwmf7NzIYQXoVyh+wYKvt1cMeYjH83VSTHgun2io+PlkXVvKE6Ak0nQn PyqB2sWZiMQQSwCL+sPuamQ8b77qAA+qYLrpjBVEbgEMaoQkA1UQOl7Hx3rzx7y5NAHc RoThu+rgX7nJu+CqjjSG6O7J8EClYH9Ed59XmZ1ZZygVhMunU3Cg4LpcJr9sPXYC+MM6 yZj9j+SV1c5QWuffEcBfI0mpQi7LKQKB+GA19ClCnr+O7rzq44gaErJ4EHPg6abLvq+6 /AJw==
X-Gm-Message-State AOPr4FXXkIP2qGMik+MdqL9nsXNmVpgnxm0dx+ekZKvdemdCA7Sq0JrxFhMQikL1hkr+dQ==
X-Received by 10.28.46.19 with SMTP id u19mr31203366wmu.98.1461849859138; Thu, 28 Apr 2016 06:24:19 -0700 (PDT)
X-Mailer git-send-email 2.8.0.rc3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 33
Organization linux.* mail to news gateway
X-Original-Cc <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, "James E.J. Bottomley" <jejb@parisc-linux.org>, Helge Deller <deller@gmx.de>, linux-arch@vger.kernel.org
X-Original-Date Thu, 28 Apr 2016 15:23:55 +0200
X-Original-Message-ID <1461849846-27209-10-git-send-email-mhocko@kernel.org>
X-Original-References <1461849846-27209-1-git-send-email-mhocko@kernel.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1390182

Show key headers only | View raw


From: Michal Hocko <mhocko@suse.com>

__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.

pmd_alloc_one allocate PMD_ORDER which is 1. This means that this flag
has never been actually useful here because it has always been used only
for PAGE_ALLOC_COSTLY requests.

Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-arch@vger.kernel.org
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/parisc/include/asm/pgalloc.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/parisc/include/asm/pgalloc.h b/arch/parisc/include/asm/pgalloc.h
index 52c3defb40c9..f08dda3f0995 100644
--- a/arch/parisc/include/asm/pgalloc.h
+++ b/arch/parisc/include/asm/pgalloc.h
@@ -63,8 +63,7 @@ static inline void pgd_populate(struct mm_struct *mm, pgd_t *pgd, pmd_t *pmd)
 
 static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
 {
-	pmd_t *pmd = (pmd_t *)__get_free_pages(GFP_KERNEL|__GFP_REPEAT,
-					       PMD_ORDER);
+	pmd_t *pmd = (pmd_t *)__get_free_pages(GFP_KERNEL, PMD_ORDER);
 	if (pmd)
 		memset(pmd, 0, PAGE_SIZE<<PMD_ORDER);
 	return pmd;
-- 
2.8.0.rc3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 09/20] parisc: get rid of superfluous __GFP_REPEAT Michal Hocko <mhocko@kernel.org> - 2016-04-28 15:30 +0200

csiph-web