Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1390169

[PATCH 13/20] s390: get rid of superfluous __GFP_REPEAT

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 13/20] s390: get rid of superfluous __GFP_REPEAT
Date Thu, 28 Apr 2016 15:30:02 +0200
Message-ID <rsUb0-3LP-29@gated-at.bofh.it> (permalink)
References <rsUaZ-3LP-3@gated-at.bofh.it>
X-Original-To Andrew Morton <akpm@linux-foundation.org>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NJKU46zlCPrhuFAGwF0eVYa5cm/8qCBfiQ/kX86pHco=; b=Duh8/XnxEQDXJyc5xSK4z3ZUpLnLI0R237GnFKMRyZZcMhV7jeXn/6EeXw/a2OS5nZ zKjhz/hX75bpJSh9Xx/zbTet3HU+8UefSMvLCCGf9+7JJJ2s1hOpsGNvG1wElg/hcVY/ pcGpIueDIUNmAgRSfehhfeQLHHt1RzlgFxWI11u/JQaJIjRSCr8vKPsBq7BZ9Vm15l5s k28abYdsJLNSO0o9yEmfqhPufAOguHhcZRoilvoAtzqYiPAND8i2SrIOnz8q5WJOmoqn OgLrbTDq27jhrEAjoj7e8s3awW04rDCpWflpQp4YgEN11T8uSu2o3H3C9E0KwPbNeGRs RTSA==
X-Gm-Message-State AOPr4FWUup7mByiO5ZrmmMu67gMozFkURt3dRJi781RabInJkYw2DWs79cv9s3Aknxa3Kg==
X-Received by 10.28.141.141 with SMTP id p135mr29998161wmd.8.1461849862123; Thu, 28 Apr 2016 06:24:22 -0700 (PDT)
X-Mailer git-send-email 2.8.0.rc3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 32
Organization linux.* mail to news gateway
X-Original-Cc <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>, linux-arch@vger.kernel.org, Heiko Carstens <heiko.carstens@de.ibm.com>
X-Original-Date Thu, 28 Apr 2016 15:23:59 +0200
X-Original-Message-ID <1461849846-27209-14-git-send-email-mhocko@kernel.org>
X-Original-References <1461849846-27209-1-git-send-email-mhocko@kernel.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1390169

Show key headers only | View raw


From: Michal Hocko <mhocko@suse.com>

__GFP_REPEAT has a rather weak semantic but since it has been introduced
around 2.6.12 it has been ignored for low order allocations.

page_table_alloc then uses the flag for a single page allocation. This
means that this flag has never been actually useful here because it has
always been used only for PAGE_ALLOC_COSTLY requests.

Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-arch@vger.kernel.org
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/s390/mm/pgalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c
index f6c3de26cda8..3f716741797a 100644
--- a/arch/s390/mm/pgalloc.c
+++ b/arch/s390/mm/pgalloc.c
@@ -198,7 +198,7 @@ unsigned long *page_table_alloc(struct mm_struct *mm)
 			return table;
 	}
 	/* Allocate a fresh page */
-	page = alloc_page(GFP_KERNEL|__GFP_REPEAT);
+	page = alloc_page(GFP_KERNEL);
 	if (!page)
 		return NULL;
 	if (!pgtable_page_ctor(page)) {
-- 
2.8.0.rc3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 13/20] s390: get rid of superfluous __GFP_REPEAT Michal Hocko <mhocko@kernel.org> - 2016-04-28 15:30 +0200

csiph-web