Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390187

[PATCH 1/5] clockevents/drivers/dw_apb_timer: Implement ->set_state_oneshot_stopped()

Show all headers | View raw

From: Jisheng Zhang <jszhang@marvell.com>

The dw_apb_timer only "supports PERIODIC mode and their drivers emulate
ONESHOT over that" as described in commit 8fff52fd5093 ("clockevents:
Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state").

Inspired by Viresh, I think the dw_apb_timer also needs to implement
the set_state_oneshot_stopped() which is called by the clkevt core,
when the next event is required at an expiry time of 'KTIME_MAX'. This
normally happens with NO_HZ_{IDLE|FULL} in both LOWRES/HIGHRES modes.

This patch makes the clockevent device to stop on such an event, to
avoid spurious interrupts, as explained by the above commit.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/clocksource/dw_apb_timer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/dw_apb_timer.c b/drivers/clocksource/dw_apb_timer.c
index 6334526..797505a 100644
--- a/drivers/clocksource/dw_apb_timer.c
+++ b/drivers/clocksource/dw_apb_timer.c
@@ -264,6 +264,7 @@ dw_apb_clockevent_init(int cpu, const char *name, unsigned rating,
 	dw_ced->ced.set_state_shutdown = apbt_shutdown;
 	dw_ced->ced.set_state_periodic = apbt_set_periodic;
 	dw_ced->ced.set_state_oneshot = apbt_set_oneshot;
+	dw_ced->ced.set_state_oneshot_stopped = apbt_shutdown;
 	dw_ced->ced.tick_resume = apbt_resume;
 	dw_ced->ced.set_next_event = apbt_next_event;
 	dw_ced->ced.irq = dw_ced->timer.irq;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PULL] clockevents for 4.7 Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-28 15:20 +0200
  [PATCH 2/5] clocksource/drivers/mtk_timer: Add __init attribute Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-28 15:30 +0200
  [PATCH 4/5] clockevents/driversi/mps2: add MPS2 Timer driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-28 15:30 +0200
  [PATCH 5/5] clocksource/drivers/tegra: Remove unused suspend/resume code Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-28 15:30 +0200
  [PATCH 3/5] dt-bindings: document the MPS2 timer bindings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-28 15:30 +0200
  [PATCH 1/5] clockevents/drivers/dw_apb_timer: Implement ->set_state_oneshot_stopped() Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-28 15:30 +0200

csiph-web