Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390127

Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus

Show all headers | View raw

On Thursday 28 April 2016 12:53:37 Mark Brown wrote:
> On Thu, Apr 28, 2016 at 12:00:26PM +0200, Arnd Bergmann wrote:
> > On Wednesday 27 April 2016 17:58:04 Sagar Dharia wrote:
> 
> > > +int slim_add_device(struct slim_controller *ctrl, struct slim_device *sbdev)
> 
> > This looks like an artifact of ancient pre-DT times. I'd say kill it off before
> > someone starts using it.
> 
> Not every architecture uses DT, and even on architectures with DT
> support it isn't always the only firmware.  In this specific case it's
> questionable how many people are going to implement Slimbus at this
> point but in general insisting that we go DT only doesn't seem great.
> 

Nothing wrong with adding support for manual board files later if
we have a good reason for it, but at the moment, this seems completely
ARM/ARM64 specific.

I don't foresee mobile phones with ACPI using this subsystem, but even
if we got them, it would be a horrible idea to use hardcoded board
specific tables in a platform file, and we should insist that whatever
firmware is present has a way to describe the slimbus devices.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V5 0/6] Introduce framework for SLIMbus device drivers Sagar Dharia <sdharia@codeaurora.org> - 2016-04-28 02:00 +0200
  [PATCH V5 3/6] slimbus: Add messaging APIs to slimbus framework Sagar Dharia <sdharia@codeaurora.org> - 2016-04-28 02:00 +0200
    Re: [PATCH V5 3/6] slimbus: Add messaging APIs to slimbus framework Arnd Bergmann <arnd@arndb.de> - 2016-04-28 12:00 +0200
  [PATCH V5 6/6] slim: qcom: Add runtime-pm support using clock-pause feature Sagar Dharia <sdharia@codeaurora.org> - 2016-04-28 02:10 +0200
  Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Arnd Bergmann <arnd@arndb.de> - 2016-04-28 12:10 +0200
    Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Mark Brown <broonie@kernel.org> - 2016-04-28 14:00 +0200
      Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Arnd Bergmann <arnd@arndb.de> - 2016-04-28 14:40 +0200
        Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Mark Brown <broonie@kernel.org> - 2016-04-28 16:40 +0200
          Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Arnd Bergmann <arnd@arndb.de> - 2016-04-28 17:10 +0200
            Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Mark Brown <broonie@kernel.org> - 2016-04-28 18:50 +0200
              Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Arnd Bergmann <arnd@arndb.de> - 2016-04-28 19:00 +0200
                Re: [PATCH V5 1/6] SLIMbus: Device management on SLIMbus Mark Brown <broonie@kernel.org> - 2016-04-29 13:20 +0200

csiph-web