Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390125

Re: [PATCH 14/14] mm, oom, compaction: prevent from should_compact_retry looping for ever for costly orders

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 14/14] mm, oom, compaction: prevent from should_compact_retry looping for ever for costly orders
Date 2016-04-28 14:40 +0200
Message-ID <rsToB-36j-3@gated-at.bofh.it> (permalink)
References <rq6im-4F2-9@gated-at.bofh.it> <rq6in-4F2-25@gated-at.bofh.it> <rsPXI-hT-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu 28-04-16 10:59:22, Vlastimil Babka wrote:
> On 04/20/2016 09:47 PM, Michal Hocko wrote:
> >From: Michal Hocko <mhocko@suse.com>
> >
> >"mm: consider compaction feedback also for costly allocation" has
> >removed the upper bound for the reclaim/compaction retries based on the
> >number of reclaimed pages for costly orders. While this is desirable
> >the patch did miss a mis interaction between reclaim, compaction and the
> >retry logic.
> 
> Hmm perhaps reversing the order of patches 13 and 14 would be a bit safer
> wrt future bisections then? Add compaction_zonelist_suitable() first with
> the reasoning, and then immediately use it in the other patch.

Hmm, I do not think the risk is high. This would require the allocate
GFP_REPEAT large orders to the last drop which is not usual. I found the
ordering more logical to argue about because this patch will be mostly
noop for costly orders without 13 and !costly allocations retry
endlessly anyway. So I would prefer this ordering even though there is
a window where an extreme load can lockup. I do not expect people
shooting their head during bisection.

[...]
> >
> >[vbabka@suse.cz: fix classzone_idx vs. high_zoneidx usage in
> >compaction_zonelist_suitable]
> >Signed-off-by: Michal Hocko <mhocko@suse.com>
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>

Thanks!

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0.14] oom detection rework v6 Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
  [PATCH 07/14] mm, compaction: Simplify __alloc_pages_direct_compact feedback interface Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
  [PATCH 03/14] mm, compaction: cover all compaction mode in compact_zone Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
  [PATCH 10/14] mm, oom: rework oom detection Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
  [PATCH 14/14] mm, oom, compaction: prevent from should_compact_retry looping for ever for costly orders Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
    Re: [PATCH 14/14] mm, oom, compaction: prevent from  should_compact_retry looping for ever for costly orders Vlastimil Babka <vbabka@suse.cz> - 2016-04-28 11:00 +0200
      Re: [PATCH 14/14] mm, oom, compaction: prevent from  should_compact_retry looping for ever for costly orders Michal Hocko <mhocko@kernel.org> - 2016-04-28 14:40 +0200
    Re: [PATCH 14/14] mm, oom, compaction: prevent from  should_compact_retry looping for ever for costly orders Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-04 08:30 +0200
      Re: [PATCH 14/14] mm, oom, compaction: prevent from  should_compact_retry looping for ever for costly orders Michal Hocko <mhocko@kernel.org> - 2016-05-04 11:10 +0200
        Re: [PATCH 14/14] mm, oom, compaction: prevent from  should_compact_retry looping for ever for costly orders Joonsoo Kim <js1304@gmail.com> - 2016-05-04 17:20 +0200
          Re: [PATCH 14/14] mm, oom, compaction: prevent from  should_compact_retry looping for ever for costly orders Michal Hocko <mhocko@kernel.org> - 2016-05-04 21:30 +0200
  [PATCH 11/14] mm: throttle on IO only when there are too many dirty and writeback pages Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
  [PATCH 12/14] mm, oom: protect !costly allocations some more Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
    Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-04 08:10 +0200
      Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-04 08:40 +0200
        Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Michal Hocko <mhocko@kernel.org> - 2016-05-04 11:00 +0200
          Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Joonsoo Kim <js1304@gmail.com> - 2016-05-04 17:00 +0200
            Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Michal Hocko <mhocko@kernel.org> - 2016-05-04 20:20 +0200
      Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Michal Hocko <mhocko@kernel.org> - 2016-05-04 11:00 +0200
        Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Joonsoo Kim <js1304@gmail.com> - 2016-05-04 16:40 +0200
          Re: [PATCH 12/14] mm, oom: protect !costly allocations some more Michal Hocko <mhocko@kernel.org> - 2016-05-04 20:30 +0200
  [PATCH 01/14] vmscan: consider classzone_idx in compaction_ready Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
    Re: [PATCH 01/14] vmscan: consider classzone_idx in compaction_ready "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-04-21 06:40 +0200
    Re: [PATCH 01/14] vmscan: consider classzone_idx in compaction_ready Michal Hocko <mhocko@kernel.org> - 2016-05-04 16:00 +0200
  [PATCH 05/14] mm, compaction: distinguish between full and partial COMPACT_COMPLETE Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
    Re: [PATCH 05/14] mm, compaction: distinguish between full and partial COMPACT_COMPLETE "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-04-21 08:40 +0200
  [PATCH 08/14] mm, compaction: Abstract compaction feedback to helpers Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
    Re: [PATCH 08/14] mm, compaction: Abstract compaction feedback to  helpers Vlastimil Babka <vbabka@suse.cz> - 2016-04-28 10:50 +0200
  [PATCH 09/14] mm: use compaction feedback for thp backoff conditions Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
    Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-04-21 09:10 +0200
    Re: [PATCH 09/14] mm: use compaction feedback for thp backoff  conditions Vlastimil Babka <vbabka@suse.cz> - 2016-04-28 11:00 +0200
      Re: [PATCH 09/14] mm: use compaction feedback for thp backoff  conditions Michal Hocko <mhocko@kernel.org> - 2016-04-28 14:40 +0200
        Re: [PATCH 09/14] mm: use compaction feedback for thp backoff  conditions Vlastimil Babka <vbabka@suse.cz> - 2016-04-29 11:20 +0200
          Re: [PATCH 09/14] mm: use compaction feedback for thp backoff  conditions Michal Hocko <mhocko@kernel.org> - 2016-04-29 11:30 +0200
  [PATCH 13/14] mm: consider compaction feedback also for costly allocation Michal Hocko <mhocko@kernel.org> - 2016-04-20 21:50 +0200
  [PATCH 04/14] mm, compaction: distinguish COMPACT_DEFERRED from COMPACT_SKIPPED Michal Hocko <mhocko@kernel.org> - 2016-04-20 22:00 +0200
  [PATCH 02/14] mm, compaction: change COMPACT_ constants into enum Michal Hocko <mhocko@kernel.org> - 2016-04-20 22:00 +0200
  Re: [PATCH 0.14] oom detection rework v6 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-04 07:50 +0200
    Re: [PATCH 0.14] oom detection rework v6 Vlastimil Babka <vbabka@suse.cz> - 2016-05-04 10:20 +0200
      Re: [PATCH 0.14] oom detection rework v6 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-04 10:40 +0200
      Re: [PATCH 0.14] oom detection rework v6 Michal Hocko <mhocko@kernel.org> - 2016-05-04 11:00 +0200
    Re: [PATCH 0.14] oom detection rework v6 Michal Hocko <mhocko@kernel.org> - 2016-05-04 10:50 +0200
      Re: [PATCH 0.14] oom detection rework v6 Joonsoo Kim <js1304@gmail.com> - 2016-05-04 16:40 +0200
        Re: [PATCH 0.14] oom detection rework v6 Michal Hocko <mhocko@kernel.org> - 2016-05-04 20:20 +0200
          Re: [PATCH 0.14] oom detection rework v6 Joonsoo Kim <js1304@gmail.com> - 2016-05-10 08:50 +0200
            Re: [PATCH 0.14] oom detection rework v6 Vlastimil Babka <vbabka@suse.cz> - 2016-05-10 09:10 +0200
              Re: [PATCH 0.14] oom detection rework v6 Joonsoo Kim <js1304@gmail.com> - 2016-05-10 10:10 +0200
                Re: [PATCH 0.14] oom detection rework v6 Michal Hocko <mhocko@kernel.org> - 2016-05-10 11:50 +0200
            Re: [PATCH 0.14] oom detection rework v6 Michal Hocko <mhocko@kernel.org> - 2016-05-10 11:50 +0200
              Re: [PATCH 0.14] oom detection rework v6 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-12 04:30 +0200
                Re: [PATCH 0.14] oom detection rework v6 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-05-12 07:20 +0200
                Re: [PATCH 0.14] oom detection rework v6 Michal Hocko <mhocko@kernel.org> - 2016-05-12 13:10 +0200

csiph-web