Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390037

Re: [PATCH] mmc: sunxi: Disable eMMC HS-DDR (MMC_CAP_1_8V_DDR) for Allwinner A80

Show all headers | View raw

On 26 April 2016 at 17:37, Chen-Yu Tsai <wens@csie.org> wrote:
> eMMC HS-DDR no longer works on the A80, despite it working when support
> for this developed.
>
> Disable it for now.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>
> Hi,
>
> When i worked on this it was working, but now it isn't. Unfortunately I
> don't have my old tree to do a proper bisect. I probably won't have time
> to dig into this issue before v4.6 release, so it's best to disable it
> on the A80 for now.
>
> Thanks.
>
> ---
>  drivers/mmc/host/sunxi-mmc.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index 8372a413848c..7fc8b7aa83f0 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -1129,6 +1129,11 @@ static int sunxi_mmc_probe(struct platform_device *pdev)
>                                   MMC_CAP_1_8V_DDR |
>                                   MMC_CAP_ERASE | MMC_CAP_SDIO_IRQ;
>
> +       /* TODO MMC DDR is not working on A80 */
> +       if (of_device_is_compatible(pdev->dev.of_node,
> +                                   "allwinner,sun9i-a80-mmc"))
> +               mmc->caps &= ~MMC_CAP_1_8V_DDR;
> +
>         ret = mmc_of_parse(mmc);
>         if (ret)
>                 goto error_free_dma;
> --
> 2.8.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: sunxi: Disable eMMC HS-DDR (MMC_CAP_1_8V_DDR) for Allwinner A80 Chen-Yu Tsai <wens@csie.org> - 2016-04-26 17:40 +0200
  Re: [PATCH] mmc: sunxi: Disable eMMC HS-DDR (MMC_CAP_1_8V_DDR) for  Allwinner A80 Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-28 12:50 +0200

csiph-web