Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1389951
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus |
| Date | 2016-04-28 12:00 +0200 |
| Message-ID | <rsQTN-10l-39@gated-at.bofh.it> (permalink) |
| References | <rsHx8-1CG-3@gated-at.bofh.it> <rsHx9-1CG-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday 27 April 2016 17:58:05 Sagar Dharia wrote:
> +#if IS_ENABLED(CONFIG_OF)
> +/* OF helpers for SLIMbus */
> +static void of_register_slim_devices(struct slim_controller *ctrl)
> +{
> + struct device_node *node;
>
The #ifdef seems useless here, what kind of system would not have CONFIG_OF
enabled? I'd suggest merging this into patch 1 and removing the conditional
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V5 2/6] of/slimbus: OF helper for SLIMbus Sagar Dharia <sdharia@codeaurora.org> - 2016-04-28 02:00 +0200
Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus Arnd Bergmann <arnd@arndb.de> - 2016-04-28 12:00 +0200
Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus Mark Rutland <mark.rutland@arm.com> - 2016-04-28 13:20 +0200
Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus Rob Herring <robh@kernel.org> - 2016-05-03 18:20 +0200
Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus Arnd Bergmann <arnd@arndb.de> - 2016-05-03 21:30 +0200
csiph-web