[PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is supported

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Shawn Lin <shawn.lin@rock-chips.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is supported
Date	Thu, 28 Apr 2016 10:50:02 +0200
Message-ID	<rsPO2-e7-13@gated-at.bofh.it> (permalink)
X-Original-To	Adrian Hunter <adrian.hunter@intel.com>, Ulf Hansson <ulf.hansson@linaro.org>
X-263anti-Spam	KSV:0;
X-Mail-Gray	1
X-Abs-Checked	4
X-Rl-Sender	shawn.lin@rock-chips.com
X-Fst-To	adrian.hunter@intel.com
X-Sender-IP	58.22.7.114
X-Login-Name	shawn.lin@rock-chips.com
X-Unique-Tag	<989924c675f4b02d5059ff400137b715>
X-Sender	lintao@rock-chips.com
X-Mailer	git-send-email 1.8.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	Michal Simek <michal.simek@xilinx.com>, soren.brinkmann@xilinx.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson <dianders@chromium.org>, Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org, Shawn Lin <shawn.lin@rock-chips.com>
X-Original-Date	Thu, 28 Apr 2016 16:38:51 +0800
X-Original-Message-ID	<1461832731-28422-1-git-send-email-shawn.lin@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1389892

Show key headers only | View raw

commit 61b914eb81f8 ("mmc: sdhci-of-arasan: add phy support for
sdhci-of-arasan") introduce phy support for arasan. According to
the vendor's databook, we should make sure the phy is in poweroff
status before we configure the clk stuff. Otherwise it may cause
some IO sample timing issues from the test. And we don't need this
extra operation while running in low performance mode since phy
doesn't trigger sampling block.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

---

Changes in v2:
- change commit msg title to indicate it's a fix
- fix a typo in commmit msg

 drivers/mmc/host/sdhci-of-arasan.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 2e482b1..20b859e 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -55,8 +55,26 @@ static unsigned int sdhci_arasan_get_timeout_clock(struct sdhci_host *host)
 	return freq;
 }
 
+static void sdhci_arasan_set_clock(struct sdhci_host *host, unsigned int clock)
+{
+	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
+	struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host);
+	bool ctrl_phy = false;
+
+	if (clock > MMC_HIGH_52_MAX_DTR && (!IS_ERR(sdhci_arasan->phy)))
+		ctrl_phy = true;
+
+	if (ctrl_phy)
+		phy_power_off(sdhci_arasan->phy);
+
+	sdhci_set_clock(host, clock);
+
+	if (ctrl_phy)
+		phy_power_on(sdhci_arasan->phy);
+}
+
 static struct sdhci_ops sdhci_arasan_ops = {
-	.set_clock = sdhci_set_clock,
+	.set_clock = sdhci_arasan_set_clock,
 	.get_max_clock = sdhci_pltfm_clk_get_max_clock,
 	.get_timeout_clock = sdhci_arasan_get_timeout_clock,
 	.set_bus_width = sdhci_set_bus_width,
-- 
2.3.7

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is supported Shawn Lin <shawn.lin@rock-chips.com> - 2016-04-28 10:50 +0200
  Re: [PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is  supported Adrian Hunter <adrian.hunter@intel.com> - 2016-04-28 12:20 +0200
  Re: [PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is supported Ulf Hansson <ulf.hansson@linaro.org> - 2016-04-28 12:40 +0200
    Re: [PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is  supported Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-04 03:50 +0200
      Re: [PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is supported Heiko Stuebner <heiko@sntech.de> - 2016-05-04 10:40 +0200
        Re: [PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is  supported Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-04 11:30 +0200
          Re: [PATCH v2] mmc: sdhci-of-arasan: fix set_clock when a phy is supported Ulf Hansson <ulf.hansson@linaro.org> - 2016-05-04 13:20 +0200

csiph-web