Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1389785
| From | Vineet Gupta <Vineet.Gupta1@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: Misleading hint to select CONFIG_PERF_EVENTS if driver sets PERF_PMU_CAP_NO_INTERRUPT |
| Date | 2016-04-28 06:40 +0200 |
| Message-ID | <rsLU5-5pL-1@gated-at.bofh.it> (permalink) |
| References | <rqJjJ-2A9-25@gated-at.bofh.it> <rsaBc-7X7-3@gated-at.bofh.it> <rsLU6-5pL-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday 27 April 2016 08:43 PM, Lada Trimasova wrote: > On Tue, 2016-04-26 at 12:42 +0000, Vineet Gupta wrote: > > On Friday 22 April 2016 06:56 PM, Lada Trimasova wrote: > I think what we have now is sufficient - but u seem to want a prettier failure output. > > Anyhow, this print is coming from util/evsel.c: perf_evsel__open_strerror() > At the very least you want another entry in switch case for ENOTSUPP and then > check if event was sampling one ( > evsel->attr.sample_period) - use that as a hint for saying sampling events not > supported. > > > > > ENOTSUPP is not visible for user programs. So it's impossible to add this entry > > to mentioned switch. > > I think that there is no good way to make error message more understandable > > without breaking existing api. I meant EOPNOTSUPP. Any errno value has to be visible to user programs otherwise there is no point defining it.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Misleading hint to select CONFIG_PERF_EVENTS if driver sets PERF_PMU_CAP_NO_INTERRUPT Lada Trimasova <Lada.Trimasova@synopsys.com> - 2016-04-22 15:30 +0200
Re: Misleading hint to select CONFIG_PERF_EVENTS if driver sets PERF_PMU_CAP_NO_INTERRUPT Lada Trimasova <Lada.Trimasova@synopsys.com> - 2016-04-26 13:00 +0200
Re: Misleading hint to select CONFIG_PERF_EVENTS if driver sets PERF_PMU_CAP_NO_INTERRUPT Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-04-26 14:50 +0200
Re: Misleading hint to select CONFIG_PERF_EVENTS if driver sets PERF_PMU_CAP_NO_INTERRUPT Lada Trimasova <Lada.Trimasova@synopsys.com> - 2016-04-27 17:20 +0200
Re: Misleading hint to select CONFIG_PERF_EVENTS if driver sets PERF_PMU_CAP_NO_INTERRUPT Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-04-28 06:40 +0200
Re: Misleading hint to select CONFIG_PERF_EVENTS if driver sets PERF_PMU_CAP_NO_INTERRUPT Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-05-05 15:30 +0200
csiph-web