Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1389769

Re: [PATCH] cpufreq: governor: Change confusing struct field and variable names

Show all headers | View raw

On 28-04-16, 01:19, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The name of the prev_cpu_wall field in struct cpu_dbs_info is
> confusing, because it doesn't represent wall time, but the previous
> update time as returned by get_cpu_idle_time() (that may be the
> current value of jiffies_64 in some cases, for example).
> 
> Moreover, the names of some related variables in dbs_update() take
> that confusion further.
> 
> Rename all of those things to make their names reflect the purpose
> more accurately.  While at it, drop unnecessary parens from one of
> the updated expressions.
> 
> No functional changes.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq_governor.c |   22 +++++++++++-----------
>  drivers/cpufreq/cpufreq_governor.h |    2 +-
>  2 files changed, 12 insertions(+), 12 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: governor: Change confusing struct field and variable names "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-04-28 01:20 +0200
  Re: [PATCH] cpufreq: governor: Change confusing struct field and  variable names Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-28 04:20 +0200
  RE: [PATCH] cpufreq: governor: Change confusing struct field and  variable names "Chen, Yu C" <yu.c.chen@intel.com> - 2016-04-28 09:10 +0200

csiph-web